Introduces window_finder_android.cc

chrome/chrome_browser_ui.gypi

 # Copyright 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     # There are two sections of sources:
     # * "Platform"-based sources (OS, toolkit, etc.)
     # * Feature/directory-based sources (e.g., history, printing)
 
@@ skipping 2366 matching lines @@
       'browser/ui/views/tabs/tab.h',
       'browser/ui/views/tabs/tab_controller.h',
       'browser/ui/views/tabs/tab_drag_controller.cc',
       'browser/ui/views/tabs/tab_drag_controller.h',
       'browser/ui/views/tabs/tab_strip.cc',
       'browser/ui/views/tabs/tab_strip.h',
       'browser/ui/views/tabs/tab_strip_controller.h',
       'browser/ui/views/tabs/tab_strip_layout.cc',
       'browser/ui/views/tabs/tab_strip_layout.h',
       'browser/ui/views/tabs/window_finder.h',
+      'browser/ui/views/tabs/window_finder_android.cc',
       'browser/ui/views/tabs/window_finder_chromeos.cc',
       'browser/ui/views/tabs/window_finder_mac.mm',
       'browser/ui/views/tabs/window_finder_win.cc',
       'browser/ui/views/task_manager_view.cc',
       'browser/ui/views/theme_image_mapper.cc',
       'browser/ui/views/theme_image_mapper.h',
       'browser/ui/views/toolbar/app_menu.cc',
       'browser/ui/views/toolbar/app_menu.h',
       'browser/ui/views/toolbar/app_menu_button.cc',
       'browser/ui/views/toolbar/app_menu_button.h',
@@ skipping 560 matching lines @@
             }],
             ['OS!="mac"', {
               'sources': [ '<@(chrome_browser_ui_views_non_mac_sources)' ],
               'dependencies': [
                 '../ui/gfx/gfx.gyp:gfx_vector_icons',
               ],
               'conditions': [
                 ['enable_extensions==1', {
                   'sources': [ '<@(chrome_browser_ui_views_extensions_non_mac_sources)' ],
                 }],
+                ['use_ash==1 or OS=="android"', {

[sky, 2015/11/06 17:26:57]

This is a subtle and confusing place to put this include. I would rather you
list window_finder_impl.cc with all sources and exclude where appropriate.

[bshe, 2015/11/06 21:13:21]

I assume you mean include the file in "chrome_browser_ui_views_non_mac_sources".
It looks like non_mac_sources is used here and also when mac_views_browser is
true on mac platform. So I need to exclude them in two different places with
condition check for android and ash. It is still not easy to read.
Instead, I added a chrome_browser_ui_views_android_sources variable and the
condition checks seem easier to read. But
I need to duplicate window_finder_impl.* in this case. So not entirely sure this
approach is better. WDYT?

+                  'sources': [ 'browser/ui/views/tabs/window_finder_impl.cc' ],
+                }],
               ],
             }],
             ['enable_extensions==1', {
               'dependencies': [
                 '<(DEPTH)/extensions/components/extensions_components.gyp:native_app_window',
               ],
             }],
           ],
         }],
         ['use_aura==1 and chromeos==0 and use_ozone==0 and OS=="linux"', {
@@ skipping 274 matching lines @@
           ],
           'sources': [
             '<@(chrome_browser_ui_non_mobile_sources)',
             '<@(chrome_browser_ui_omnibox_non_mobile_sources)',
           ],
         }],
       ],
     },
   ],
 }