Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1421003004: Add CoreClasses (Closed)

Created:
5 years, 1 month ago by Johnni Winther
Modified:
5 years, 1 month ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+486 lines, -355 lines) Patch
M pkg/compiler/lib/src/common/backend_api.dart View 1 chunk +22 lines, -20 lines 0 comments Download
M pkg/compiler/lib/src/compile_time_constants.dart View 9 chunks +19 lines, -16 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 6 chunks +19 lines, -35 lines 0 comments Download
M pkg/compiler/lib/src/core_types.dart View 1 chunk +54 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/inferrer_visitor.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart View 4 chunks +15 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 19 chunks +65 lines, -47 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_impact.dart View 11 chunks +16 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/glue.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_system_javascript.dart View 3 chunks +12 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/js_backend.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/namer.dart View 3 chunks +6 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/no_such_method_registry.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/runtime_types.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 5 chunks +13 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/lazy_emitter/emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/lazy_emitter/model_emitter.dart View 2 chunks +6 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/native_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/collector.dart View 4 chunks +10 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 4 chunks +13 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart View 3 chunks +4 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/mirrors/dart2js_type_mirrors.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/native/enqueue.dart View 2 chunks +9 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/ordered_typeset.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/class_hierarchy.dart View 8 chunks +18 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/resolution/class_members.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/constructors.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 12 chunks +23 lines, -19 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 6 chunks +10 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 11 chunks +15 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 10 chunks +16 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/ssa/nodes.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 1 5 chunks +16 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/ssa/ssa.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/types.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/typechecker.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/world.dart View 4 chunks +13 lines, -9 lines 0 comments Download
M tests/compiler/dart2js/expect_annotations_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/mirrors_used_test.dart View 1 chunk +7 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/related_types.dart View 4 chunks +5 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/resolver_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/simple_inferrer_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/simple_inferrer_try_catch_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/trust_type_annotations_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/type_checker_test.dart View 1 chunk +4 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/type_combination_test.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/type_mask_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/union_type_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
Main changes in core_types.dart and compiler.dart.
5 years, 1 month ago (2015-10-26 10:10:36 UTC) #2
sigurdm
LGTM https://codereview.chromium.org/1421003004/diff/1/pkg/compiler/lib/src/ssa/optimize.dart File pkg/compiler/lib/src/ssa/optimize.dart (right): https://codereview.chromium.org/1421003004/diff/1/pkg/compiler/lib/src/ssa/optimize.dart#newcode684 pkg/compiler/lib/src/ssa/optimize.dart:684: if (element == coreClasses.objectClass || type.treatAsDynamic) { use ...
5 years, 1 month ago (2015-10-26 11:43:23 UTC) #3
Johnni Winther
https://codereview.chromium.org/1421003004/diff/1/pkg/compiler/lib/src/ssa/optimize.dart File pkg/compiler/lib/src/ssa/optimize.dart (right): https://codereview.chromium.org/1421003004/diff/1/pkg/compiler/lib/src/ssa/optimize.dart#newcode684 pkg/compiler/lib/src/ssa/optimize.dart:684: if (element == coreClasses.objectClass || type.treatAsDynamic) { On 2015/10/26 ...
5 years, 1 month ago (2015-10-26 12:50:42 UTC) #4
Johnni Winther
5 years, 1 month ago (2015-10-26 12:56:33 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
db98c37dacf94f30931498038230be8aa7f8bafe (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698