Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(871)

Unified Diff: pkg/compiler/lib/src/js_backend/backend_impact.dart

Issue 1421003004: Add CoreClasses (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Updated cf. comment. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/js_backend/backend.dart ('k') | pkg/compiler/lib/src/js_backend/codegen/glue.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_backend/backend_impact.dart
diff --git a/pkg/compiler/lib/src/js_backend/backend_impact.dart b/pkg/compiler/lib/src/js_backend/backend_impact.dart
index 650645ed9ef2c1a0dfe9cf18d06a6947126c9bee..7ced4461dd3cfbb70d7a5a0d6e25f46836aad62b 100644
--- a/pkg/compiler/lib/src/js_backend/backend_impact.dart
+++ b/pkg/compiler/lib/src/js_backend/backend_impact.dart
@@ -8,6 +8,8 @@ import '../common/names.dart' show
Identifiers;
import '../compiler.dart' show
Compiler;
+import '../core_types.dart' show
+ CoreClasses;
import '../dart_types.dart' show
InterfaceType;
import '../elements/elements.dart' show
@@ -41,6 +43,8 @@ class BackendImpacts {
BackendHelpers get helpers => backend.helpers;
+ CoreClasses get coreClasses => compiler.coreClasses;
+
BackendImpact get getRuntimeTypeArgument => new BackendImpact(
staticUses: [
helpers.getRuntimeTypeArgument,
@@ -54,7 +58,7 @@ class BackendImpacts {
helpers.computeSignature,
helpers.getRuntimeTypeArguments],
instantiatedClasses: [
- compiler.listClass]);
+ coreClasses.listClass]);
BackendImpact get asyncBody => new BackendImpact(
staticUses: [
@@ -118,13 +122,12 @@ class BackendImpacts {
helpers.throwRuntimeError],
// Also register the types of the arguments passed to this method.
instantiatedClasses: [
- helpers.compiler.stringClass]);
+ coreClasses.stringClass]);
BackendImpact get superNoSuchMethod => new BackendImpact(
staticUses: [
helpers.createInvocationMirror,
- helpers.compiler.objectClass.lookupLocalMember(
- Identifiers.noSuchMethod_)],
+ coreClasses.objectClass.lookupLocalMember(Identifiers.noSuchMethod_)],
otherImpacts: [
needsInt(
'Needed to encode the invocation kind of super.noSuchMethod.'),
@@ -153,7 +156,7 @@ class BackendImpacts {
BackendImpact get constSymbol => new BackendImpact(
instantiatedClasses: [
- compiler.symbolClass],
+ coreClasses.symbolClass],
staticUses: [
compiler.symbolConstructor.declaration]);
@@ -164,14 +167,14 @@ class BackendImpacts {
BackendImpact needsInt(String reason) {
// TODO(johnniwinther): Register [reason] for use in dump-info.
return new BackendImpact(
- instantiatedClasses: [helpers.compiler.intClass]);
+ instantiatedClasses: [coreClasses.intClass]);
}
/// Helper for registering that `List` is needed.
BackendImpact needsList(String reason) {
// TODO(johnniwinther): Register [reason] for use in dump-info.
return new BackendImpact(
- instantiatedClasses: [helpers.compiler.listClass]);
+ instantiatedClasses: [coreClasses.listClass]);
}
/// Helper for registering that `String` is needed.
@@ -179,7 +182,7 @@ class BackendImpacts {
// TODO(johnniwinther): Register [reason] for use in dump-info.
return new BackendImpact(
instantiatedClasses: [
- helpers.compiler.stringClass]);
+ coreClasses.stringClass]);
}
BackendImpact get assertWithoutMessage => new BackendImpact(
@@ -226,7 +229,7 @@ class BackendImpacts {
BackendImpact get stackTraceInCatch => new BackendImpact(
instantiatedClasses: [
- helpers.compiler.stackTraceClass],
+ coreClasses.stackTraceClass],
staticUses: [
helpers.traceFromException]);
@@ -243,14 +246,14 @@ class BackendImpacts {
helpers.runtimeTypeToString,
helpers.createRuntimeType],
instantiatedClasses: [
- helpers.compiler.listClass],
+ coreClasses.listClass],
otherImpacts: [
getRuntimeTypeArgument,
needsInt('Needed for accessing a type variable literal on this.')]);
BackendImpact get typeCheck => new BackendImpact(
instantiatedClasses: [
- helpers.compiler.boolClass]);
+ coreClasses.boolClass]);
BackendImpact get checkedModeTypeCheck => new BackendImpact(
staticUses: [
@@ -267,7 +270,7 @@ class BackendImpacts {
helpers.setRuntimeTypeInfo,
helpers.getRuntimeTypeInfo],
instantiatedClasses: [
- helpers.compiler.listClass],
+ coreClasses.listClass],
otherImpacts: [
getRuntimeTypeArgument]);
@@ -296,5 +299,5 @@ class BackendImpacts {
BackendImpact get closure => new BackendImpact(
instantiatedClasses: [
- helpers.compiler.functionClass]);
+ coreClasses.functionClass]);
}
« no previous file with comments | « pkg/compiler/lib/src/js_backend/backend.dart ('k') | pkg/compiler/lib/src/js_backend/codegen/glue.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698