Add connecting/connectable to bluetooth.Device.

Add connecting/connectable to bluetooth.Device.

BUG=543294
For auto-generated externs:
TBR=dbeam@chromium.org

Committed: https://crrev.com/fdfbc12a6828295e52d493d917a0b8f3d1babe69
Cr-Commit-Position: refs/heads/master@{#358725}

[stevenjb, 2015-10-29 17:33:22]

stevenjb@chromium.org changed reviewers:
+ armansito@chromium.org

[stevenjb, 2015-11-05 18:51:19]

stevenjb@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[stevenjb, 2015-11-05 18:51:19]

armansito: ping
rdevlin: minor IDL changes

[Devlin, 2015-11-05 19:27:58]

https://codereview.chromium.org/1420973007/diff/40001/extensions/common/api/b...
File extensions/common/api/bluetooth.idl (right):

https://codereview.chromium.org/1420973007/diff/40001/extensions/common/api/b...
extensions/common/api/bluetooth.idl:70: boolean? connecting;
It's a shame we're adding so many of these, since it seems like there's a lot of
overlap (connected or connecting implies connectable, connected implies not
connecting, etc).  Ideally, these (and maybe paired) probably would have been a
single enum.  Unfortunately, the ship has probably sailed on that.

That said, what's the concrete use case for these?  I don't actually see a
"connect" method or anything...

If this change is only advantageous for the private API, we shouldn't be putting
it here (and can instead do something like getDeviceStatus as a private API
function).

[stevenjb, 2015-11-05 19:37:54]

https://codereview.chromium.org/1420973007/diff/40001/extensions/common/api/b...
File extensions/common/api/bluetooth.idl (right):

https://codereview.chromium.org/1420973007/diff/40001/extensions/common/api/b...
extensions/common/api/bluetooth.idl:70: boolean? connecting;
On 2015/11/05 19:27:58, Devlin wrote:
> It's a shame we're adding so many of these, since it seems like there's a lot
of
> overlap (connected or connecting implies connectable, connected implies not
> connecting, etc).  Ideally, these (and maybe paired) probably would have been
a
> single enum.  Unfortunately, the ship has probably sailed on that.
> 
> That said, what's the concrete use case for these?  I don't actually see a
> "connect" method or anything...
> 
> If this change is only advantageous for the private API, we shouldn't be
putting
> it here (and can instead do something like getDeviceStatus as a private API
> function).

paired/connecting/connected could theoretically be combined, but as you mention
it would break backwards compatibility, and frankly, based on my experience with
the networking UI, enums are overrated.

The complete state is useful independent of the private API. 'connecting' in
particular would be useful for showing the status. 'connectable' slightly less
so, but it hardly seems worth the added complexity of adding a separate 'Status'
type (which I think would be very confusing) just for that.

[Devlin, 2015-11-05 19:42:31]

lgtm

[armansito, 2015-11-09 22:04:56]

lgtm

[stevenjb, 2015-11-09 23:40:07]

Description was changed from

==========
Add connecting/connectable to bluetooth.Device.

BUG=543294
==========

to

==========
Add connecting/connectable to bluetooth.Device.

BUG=543294
For auto-generated externs:
TBR=dbeam@chromium.org
==========

[stevenjb, 2015-11-09 23:40:12]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2015-11-09 23:40:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
armansito@chromium.org, rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/1420973007/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2015-11-09 23:41:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1420973007/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1420973007/60001

[commit-bot: I haz the power, 2015-11-10 01:17:18]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-11-10 01:17:49]

Patchset 4 (id:??) landed as
https://crrev.com/fdfbc12a6828295e52d493d917a0b8f3d1babe69
Cr-Commit-Position: refs/heads/master@{#358725}