Clarify subrect semantics for GrTextureAdjuster and handle mip maps correctly.

Clarify subrect semantics for GrTextureAdjuster and handle mip maps correctly.

Committed: https://skia.googlesource.com/skia/+/c75be34b4600d3acb5b076e6545efb05cce4abe6

[bsalomon, 2015-10-29 17:48:10]

bsalomon@google.com changed reviewers:
+ robertphillips@google.com

[bsalomon, 2015-10-29 17:48:10]

Small update to previous CL

[robertphillips, 2015-10-29 17:54:52]

lgtm

https://codereview.chromium.org/1410383008/diff/40001/src/gpu/GrTextureParams...
File src/gpu/GrTextureParamsAdjuster.h (right):

https://codereview.chromium.org/1410383008/diff/40001/src/gpu/GrTextureParams...
src/gpu/GrTextureParamsAdjuster.h:73: * Base class for sources that start out as
textures. Optionally allows for a content area subrect.
not to use -> is to not use ?

WDYT about a debug mode where we fill outside with red ?

[bsalomon, 2015-10-29 19:14:20]

https://codereview.chromium.org/1410383008/diff/40001/src/gpu/GrTextureParams...
File src/gpu/GrTextureParamsAdjuster.h (right):

https://codereview.chromium.org/1410383008/diff/40001/src/gpu/GrTextureParams...
src/gpu/GrTextureParamsAdjuster.h:73: * Base class for sources that start out as
textures. Optionally allows for a content area subrect.
On 2015/10/29 17:54:52, robertphillips wrote:
> not to use -> is to not use ?

Done.

> 
> WDYT about a debug mode where we fill outside with red ?


Good idea. I'll try an experiment.

[bsalomon, 2015-10-29 19:14:27]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-10-29 19:14:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1410383008/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1410383008/60001

[commit-bot: I haz the power, 2015-10-29 19:26:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-29 19:26:34]

Dry run: This issue passed the CQ dry run.

[bsalomon, 2015-10-29 19:33:41]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2015-10-29 19:33:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1410383008/#ps60001
(title: "Address comment")

[commit-bot: I haz the power, 2015-10-29 19:33:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1410383008/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1410383008/60001

[commit-bot: I haz the power, 2015-10-29 19:34:34]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/c75be34b4600d3acb5b076e6545efb05cce4abe6