Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 142093003: Fix get_landmines builder() (Closed)

Created:
6 years, 11 months ago by scottmg
Modified:
6 years, 11 months ago
Reviewers:
iannucci, Siva Chandra
CC:
chromium-reviews
Visibility:
Public.

Description

Fix get_landmines builder() This meant the script wasn't doing anything on most branches of the ifs. Is it going to cause problems to fix this? I guess basically everything will clobber. R=iannucci@chromium.org, sivachandra@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245776

Patch Set 1 #

Patch Set 2 : reitveld #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/get_landmines.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
scottmg
wdyt?
6 years, 11 months ago (2014-01-17 21:52:43 UTC) #1
Siva Chandra
This is clearly my miss when I refactored the landmines script. iannucci@ should say more ...
6 years, 11 months ago (2014-01-17 22:02:50 UTC) #2
scottmg
On 2014/01/17 22:02:50, Siva Chandra wrote: > This is clearly my miss when I refactored ...
6 years, 11 months ago (2014-01-17 22:11:57 UTC) #3
iannucci
Yeah, this lgtm, though it will cause a sweep of clobbers. I will CQ it ...
6 years, 11 months ago (2014-01-17 23:02:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/142093003/20001
6 years, 11 months ago (2014-01-18 07:05:16 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-18 16:21:15 UTC) #6
Message was sent while issue was closed.
Change committed as 245776

Powered by Google App Engine
This is Rietveld 408576698