Use worst-fit allocation in old space for prentured objects.

Use worst-fit allocation in old space for prentured objects.

BUG=

[Michael Starzinger, 2013-04-16 13:29:27]

https://codereview.chromium.org/14208005/diff/3001/src/spaces.cc
File src/spaces.cc (right):

https://codereview.chromium.org/14208005/diff/3001/src/spaces.cc#newcode2265
src/spaces.cc:2265: if (node != NULL) return node;
Missing statistical book-keeping about available_in_huge_free_list here.

https://codereview.chromium.org/14208005/diff/3001/src/spaces.cc#newcode2269
src/spaces.cc:2269: if (node != NULL) return node;
Missing statistical book-keeping about available_in_large_free_list here.

https://codereview.chromium.org/14208005/diff/3001/src/spaces.cc#newcode2274
src/spaces.cc:2274: if (node != NULL) return node;
Missing statistical book-keeping about available_in_medium_free_list here.

https://codereview.chromium.org/14208005/diff/3001/src/spaces.cc#newcode2283
src/spaces.cc:2283: Page* page = NULL;
nit: Move the declaration of "page" down into the conditionals where it's
actually used. Local code FTW.

https://codereview.chromium.org/14208005/diff/3001/src/spaces.cc#newcode2312
src/spaces.cc:2312: return FindNodeInHugeList(size_in_bytes, node_size);
Missing statistical book-keeping about available_in_huge_free_list here.

https://codereview.chromium.org/14208005/diff/3001/src/spaces.cc#newcode2319
src/spaces.cc:2319: 
nit: Add second empty newline.

https://codereview.chromium.org/14208005/diff/3001/src/spaces.h
File src/spaces.h (right):

https://codereview.chromium.org/14208005/diff/3001/src/spaces.h#newcode1576
src/spaces.h:1576: // and it ignores the smalles category.
nit: s/smalles/smallest/

[Hannes Payer (out of office), 2013-04-16 13:41:04]

https://codereview.chromium.org/14208005/diff/3001/src/spaces.cc
File src/spaces.cc (right):

https://codereview.chromium.org/14208005/diff/3001/src/spaces.cc#newcode2265
src/spaces.cc:2265: if (node != NULL) return node;
On 2013/04/16 13:29:27, Michael Starzinger wrote:
> Missing statistical book-keeping about available_in_huge_free_list here.

Done.

https://codereview.chromium.org/14208005/diff/3001/src/spaces.cc#newcode2269
src/spaces.cc:2269: if (node != NULL) return node;
On 2013/04/16 13:29:27, Michael Starzinger wrote:
> Missing statistical book-keeping about available_in_large_free_list here.

Done.

https://codereview.chromium.org/14208005/diff/3001/src/spaces.cc#newcode2274
src/spaces.cc:2274: if (node != NULL) return node;
On 2013/04/16 13:29:27, Michael Starzinger wrote:
> Missing statistical book-keeping about available_in_medium_free_list here.

Done.

https://codereview.chromium.org/14208005/diff/3001/src/spaces.cc#newcode2283
src/spaces.cc:2283: Page* page = NULL;
On 2013/04/16 13:29:27, Michael Starzinger wrote:
> nit: Move the declaration of "page" down into the conditionals where it's
> actually used. Local code FTW.

Done.

https://codereview.chromium.org/14208005/diff/3001/src/spaces.cc#newcode2312
src/spaces.cc:2312: return FindNodeInHugeList(size_in_bytes, node_size);
On 2013/04/16 13:29:27, Michael Starzinger wrote:
> Missing statistical book-keeping about available_in_huge_free_list here.

Done.

https://codereview.chromium.org/14208005/diff/3001/src/spaces.cc#newcode2319
src/spaces.cc:2319: 
On 2013/04/16 13:29:27, Michael Starzinger wrote:
> nit: Add second empty newline.

Done.

https://codereview.chromium.org/14208005/diff/3001/src/spaces.h
File src/spaces.h (right):

https://codereview.chromium.org/14208005/diff/3001/src/spaces.h#newcode1576
src/spaces.h:1576: // and it ignores the smalles category.
On 2013/04/16 13:29:27, Michael Starzinger wrote:
> nit: s/smalles/smallest/

Done.

[Michael Starzinger, 2013-04-16 14:26:09]

LGTM.

[Hannes Payer (out of office), 2013-04-24 13:56:42]

I fixed the allocation statistics bug and the resulting performance regression.
I added a new heuristic AggressivePromotionMode which allows a larger old
generation when objects are pretenured.