Issue 1420783002: Add quotation marks around probability value in Alternative Services.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1420783002: Add quotation marks around probability value in Alternative Services. (Closed)

Created:
5 years, 2 months ago by Bence

Modified:
5 years, 2 months ago

Reviewers:

CC:
chromium-reviews, asanka, benjhayden+dwatch_chromium.org, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2526

Target Ref:
refs/pending/branch-heads/2526

Project:
chromium

Visibility:
Public.

Add quotation marks around probability value in Alternative Services. Change SpdyAltSvcWireFormat to quote probability value to conform to server syntax. This CL lands server change 105446949 by bnc. BUG=543366 Review URL: https://codereview.chromium.org/1407643005 Cr-Commit-Position: refs/heads/master@{#354496} (cherry picked from commit 44858c8a031fc46bb4ba11c94fee9869db3b66f1) TBR=rch@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/00c5763360aea1df78cf804b39ff1ae5917bed4c

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -12 lines)			Patch
M	net/http/http_network_transaction_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/quic_network_transaction_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/spdy/spdy_alt_svc_wire_format.cc	View	2 chunks	+6 lines, -2 lines	0 comments	Download
M	net/spdy/spdy_alt_svc_wire_format_test.cc	View	4 chunks	+7 lines, -6 lines	0 comments	Download
M	net/spdy/spdy_framer_test.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 2 (1 generated)

Bence

5 years, 2 months ago (2015-10-21 18:34:28 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
00c5763360aea1df78cf804b39ff1ae5917bed4c (presubmit successful).