Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1407643005: Add quotation marks around probability value in Alternative Services. (Closed)

Created:
5 years, 2 months ago by Bence
Modified:
5 years, 2 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add quotation marks around probability value in Alternative Services. Change SpdyAltSvcWireFormat to quote probability value to conform to server syntax. This CL lands server change 105446949 by bnc. BUG=543366 Committed: https://crrev.com/44858c8a031fc46bb4ba11c94fee9869db3b66f1 Cr-Commit-Position: refs/heads/master@{#354496}

Patch Set 1 #

Patch Set 2 : Fix tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -19 lines) Patch
M net/http/http_network_transaction_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_network_transaction_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_alt_svc_wire_format.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M net/spdy/spdy_alt_svc_wire_format_test.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M net/spdy/spdy_framer_test.cc View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Bence
Ryan: PTAL. Thanks.
5 years, 2 months ago (2015-10-15 15:23:56 UTC) #2
Ryan Hamilton
Can you confirm that if you build Chrome with this code, and you enable alt-svc ...
5 years, 2 months ago (2015-10-15 17:54:20 UTC) #3
Bence
On 2015/10/15 17:54:20, Ryan Hamilton wrote: > Can you confirm that if you build Chrome ...
5 years, 2 months ago (2015-10-16 11:28:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407643005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407643005/20001
5 years, 2 months ago (2015-10-16 11:28:47 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-16 11:57:28 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-16 11:58:04 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/44858c8a031fc46bb4ba11c94fee9869db3b66f1
Cr-Commit-Position: refs/heads/master@{#354496}

Powered by Google App Engine
This is Rietveld 408576698