Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 1420693005: Fix spacing for JSCollection, JSSet, and JSMap.

Created:
5 years, 1 month ago by evanlucas
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix spacing for JSCollection, JSSet, and JSMap. tools/gen-postmortem-metadata.py skips JSCollection, JSSet, and JSMap due to the spacing in objects.h. This change allows them to be picked up. R=machenbach@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.h View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
evanlucas
5 years, 1 month ago (2015-11-10 00:59:31 UTC) #1
Michael Achenbach
lgtm
5 years, 1 month ago (2015-11-10 06:56:51 UTC) #3
Jakob Kummerow
ACK. Semantic meaning of spaces is a horrible, horrible hack. I would appreciate it if ...
5 years, 1 month ago (2015-11-10 09:38:18 UTC) #4
evanlucas
On 2015/11/10 09:38:18, Jakob wrote: > ACK. > > Semantic meaning of spaces is a ...
5 years, 1 month ago (2015-11-10 11:54:12 UTC) #5
evanlucas
5 years, 1 month ago (2015-11-10 14:31:23 UTC) #6
On 2015/11/10 11:54:12, evan.lucas wrote:
> On 2015/11/10 09:38:18, Jakob wrote:
> > ACK.
> > 
> > Semantic meaning of spaces is a horrible, horrible hack. I would appreciate
it
> > if gen-postmortem-metadata.py could migrate to a saner approach, e.g. one
of:
> > (1) Have a marker comment like "// GEN-POSTMORTEM-METADATA" on the line of
the
> > class definition, or the line before, or maybe reverse its meaning ("//
> > NO-POSTMORTEM-METADATA") and annotate classes that should be ignored.
> > (2) Stop making that distinction at all. Would that hurt? Things seem pretty
> > inconsistent right now anyway.
> > (3) Have a blacklist (as a Python dictionary) right inside the script, leave
> > objects.h alone entirely.
> 
> Is that something you would like to see done here instead?

I submitted https://codereview.chromium.org/1435643002 as an alternative

Powered by Google App Engine
This is Rietveld 408576698