Remove [TreatNullAs=NullString] from the 'dir' attribute on Document

Remove [TreatNullAs=NullString] from the 'dir' attribute on Document

Current behavior:
Chrome: document.dir=null => ""
Edge: document.dir=null => ""
Firefox Nightly: document.dir=null => ""

The getter and setter for 'dir' forwards to the documentElement (if it
is an HTMLHtmlElement), hence adding tests for:

document.documentElement.getAttribute('dir') => 'null'

BUG=497307
Committed: https://crrev.com/a7d96a1f1b53a8c6af526c178aefb574dbb2e744
Cr-Commit-Position: refs/heads/master@{#357549}

[tanay.c, 2015-11-02 10:36:41]

Description was changed from

==========
Remove [TreatNullAs=NullString] from the 'dir' attribute on Document

BUG=497307
==========

to

==========
Remove [TreatNullAs=NullString] from the 'dir' attribute on Document

Current behavior:
Chrome: document.dir=null => ""
Edge: document.dir=null => ""
Firefox Nightly: document.dir=null => ""

Change does not effect current behaviour

BUG=497307
==========

[tanay.c, 2015-11-02 10:36:41]

tanay.c@samsung.com changed reviewers:
+ philipj@opera.com

[tanay.c, 2015-11-02 11:47:53]

PTAL.

[philipj_slow, 2015-11-02 12:53:49]

Please write in the description *why* this change is not observable. It seems to
me that the change must be observable, because:

void HTMLElement::setDir(const AtomicString& value)
{
    setAttribute(dirAttr, value);
}

In other words, your testing needs to also include
document.documentElement.getAttribute("dir"), which will have changed.

[tanay.c, 2015-11-03 10:06:26]

Description was changed from

==========
Remove [TreatNullAs=NullString] from the 'dir' attribute on Document

Current behavior:
Chrome: document.dir=null => ""
Edge: document.dir=null => ""
Firefox Nightly: document.dir=null => ""

Change does not effect current behaviour

BUG=497307
==========

to

==========
Remove [TreatNullAs=NullString] from the 'dir' attribute on Document

Current behavior:
Chrome: document.dir=null => ""
Edge: document.dir=null => ""
Firefox Nightly: document.dir=null => ""

Change does not effect current behaviour on document.dir

The getter and setter for 'dir' forwards to the documentElement ( if it is an
HTMLHtmlElement ) , hence checking 

document.documentElement.getAttribute('dir') => 'null'

BUG=497307
==========

[tanay.c, 2015-11-03 10:07:15]

Description was changed from

==========
Remove [TreatNullAs=NullString] from the 'dir' attribute on Document

Current behavior:
Chrome: document.dir=null => ""
Edge: document.dir=null => ""
Firefox Nightly: document.dir=null => ""

Change does not effect current behaviour on document.dir

The getter and setter for 'dir' forwards to the documentElement ( if it is an
HTMLHtmlElement ) , hence checking 

document.documentElement.getAttribute('dir') => 'null'

BUG=497307
==========

to

==========
Remove [TreatNullAs=NullString] from the 'dir' attribute on Document

Current behavior:
Chrome: document.dir=null => ""
Edge: document.dir=null => ""
Firefox Nightly: document.dir=null => ""

Change does not effect current behaviour on document.dir

The getter and setter for 'dir' forwards to the documentElement ( if it is an
HTMLHtmlElement ) , hence adding tests for  

document.documentElement.getAttribute('dir') => 'null'

BUG=497307
==========

[tanay.c, 2015-11-03 10:07:41]

Description was changed from

==========
Remove [TreatNullAs=NullString] from the 'dir' attribute on Document

Current behavior:
Chrome: document.dir=null => ""
Edge: document.dir=null => ""
Firefox Nightly: document.dir=null => ""

Change does not effect current behaviour on document.dir

The getter and setter for 'dir' forwards to the documentElement ( if it is an
HTMLHtmlElement ) , hence adding tests for  

document.documentElement.getAttribute('dir') => 'null'

BUG=497307
==========

to

==========
Remove [TreatNullAs=NullString] from the 'dir' attribute on Document

Current behavior:
Chrome: document.dir=null => ""
Edge: document.dir=null => ""
Firefox Nightly: document.dir=null => ""

Change does not effect current behaviour on document.dir

The getter and setter for 'dir' forwards to the documentElement ( if it is an
HTMLHtmlElement ) .
Hence adding tests for :

document.documentElement.getAttribute('dir') => 'null'

BUG=497307
==========

[tanay.c, 2015-11-03 10:08:06]

Description was changed from

==========
Remove [TreatNullAs=NullString] from the 'dir' attribute on Document

Current behavior:
Chrome: document.dir=null => ""
Edge: document.dir=null => ""
Firefox Nightly: document.dir=null => ""

Change does not effect current behaviour on document.dir

The getter and setter for 'dir' forwards to the documentElement ( if it is an
HTMLHtmlElement ) .
Hence adding tests for :

document.documentElement.getAttribute('dir') => 'null'

BUG=497307
==========

to

==========
Remove [TreatNullAs=NullString] from the 'dir' attribute on Document

Current behavior:
Chrome: document.dir=null => ""
Edge: document.dir=null => ""
Firefox Nightly: document.dir=null => ""

Change does not effect current behaviour on document.dir

The getter and setter for 'dir' forwards to the documentElement (if it is an
HTMLHtmlElement )

Hence adding tests for :

document.documentElement.getAttribute('dir') => 'null'

BUG=497307
==========

[tanay.c, 2015-11-03 10:23:33]

On 2015/11/02 12:53:49, philipj wrote:
> Please write in the description *why* this change is not observable. It seems
to
> me that the change must be observable, because:
> 
> void HTMLElement::setDir(const AtomicString& value)
> {
>     setAttribute(dirAttr, value);
> }
> 
> In other words, your testing needs to also include
> document.documentElement.getAttribute("dir"), which will have changed.

Updated the tests to check for document.documentElement.getAttribute("dir").
Updated description. PTAL.

[philipj_slow, 2015-11-03 10:58:09]

Description was changed from

==========
Remove [TreatNullAs=NullString] from the 'dir' attribute on Document

Current behavior:
Chrome: document.dir=null => ""
Edge: document.dir=null => ""
Firefox Nightly: document.dir=null => ""

Change does not effect current behaviour on document.dir

The getter and setter for 'dir' forwards to the documentElement (if it is an
HTMLHtmlElement )

Hence adding tests for :

document.documentElement.getAttribute('dir') => 'null'

BUG=497307
==========

to

==========
Remove [TreatNullAs=NullString] from the 'dir' attribute on Document

Current behavior:
Chrome: document.dir=null => ""
Edge: document.dir=null => ""
Firefox Nightly: document.dir=null => ""

Change does not effect current behaviour on document.dir

The getter and setter for 'dir' forwards to the documentElement (if it is an
HTMLHtmlElement)

Hence adding tests for:

document.documentElement.getAttribute('dir') => 'null'

BUG=497307
==========

[philipj_slow, 2015-11-03 11:00:23]

https://codereview.chromium.org/1420593005/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/dom/document-dir-property.html (right):

https://codereview.chromium.org/1420593005/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/document-dir-property.html:57:
shouldNotThrow("document.dir = 'RTL'");
After this and the WRONG case, test that the content attribute is 'RTL' and
'WRONG' respectively. (In other words, it's just set verbatim.)

[tanay.c, 2015-11-03 11:32:59]

PTAL.

https://codereview.chromium.org/1420593005/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/dom/document-dir-property.html (right):

https://codereview.chromium.org/1420593005/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/document-dir-property.html:57:
shouldNotThrow("document.dir = 'RTL'");
On 2015/11/03 11:00:23, philipj wrote:
> After this and the WRONG case, test that the content attribute is 'RTL' and
> 'WRONG' respectively. (In other words, it's just set verbatim.)

Done.

[philipj_slow, 2015-11-03 12:45:38]

Description was changed from

==========
Remove [TreatNullAs=NullString] from the 'dir' attribute on Document

Current behavior:
Chrome: document.dir=null => ""
Edge: document.dir=null => ""
Firefox Nightly: document.dir=null => ""

Change does not effect current behaviour on document.dir

The getter and setter for 'dir' forwards to the documentElement (if it is an
HTMLHtmlElement)

Hence adding tests for:

document.documentElement.getAttribute('dir') => 'null'

BUG=497307
==========

to

==========
Remove [TreatNullAs=NullString] from the 'dir' attribute on Document

Current behavior:
Chrome: document.dir=null => ""
Edge: document.dir=null => ""
Firefox Nightly: document.dir=null => ""

The getter and setter for 'dir' forwards to the documentElement (if it
is an HTMLHtmlElement), hence adding tests for:

document.documentElement.getAttribute('dir') => 'null'

BUG=497307
==========

[philipj_slow, 2015-11-03 12:45:52]

The CQ bit was checked by philipj@opera.com

[philipj_slow, 2015-11-03 12:45:52]

lgtm

[commit-bot: I haz the power, 2015-11-03 12:46:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1420593005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1420593005/60001

[commit-bot: I haz the power, 2015-11-03 15:04:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-03 15:04:08]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[philipj_slow, 2015-11-03 15:40:06]

The CQ bit was checked by philipj@opera.com

[commit-bot: I haz the power, 2015-11-03 15:41:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1420593005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1420593005/60001

[commit-bot: I haz the power, 2015-11-03 18:15:14]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-11-03 18:16:44]

Patchset 4 (id:??) landed as
https://crrev.com/a7d96a1f1b53a8c6af526c178aefb574dbb2e744
Cr-Commit-Position: refs/heads/master@{#357549}