third_party/WebKit/Source/core/dom/Document.idl - Issue 1420593005: Remove [TreatNullAs=NullString] from the 'dir' attribute on Document

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Document.idl

Issue 1420593005: Remove [TreatNullAs=NullString] from the 'dir' attribute on Document (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/dom/Document.idl

diff --git a/third_party/WebKit/Source/core/dom/Document.idl b/third_party/WebKit/Source/core/dom/Document.idl

index 360e467aefbdd0305b88f682952488afa1986720..3f71ed5f2ae312b8224c138f19ca25cc791a8f87 100644

--- a/third_party/WebKit/Source/core/dom/Document.idl

+++ b/third_party/WebKit/Source/core/dom/Document.idl

@@ -97,8 +97,7 @@ interface Document : Node {

// DOM tree accessors

[CustomElementCallbacks] attribute DOMString title;

- // FIXME: dir should not have [TreatNullAs=NullString].

- [TreatNullAs=NullString, CustomElementCallbacks] attribute DOMString dir;

+ [CustomElementCallbacks] attribute DOMString dir;

[RaisesException=Setter, CustomElementCallbacks, PerWorldBindings, TypeChecking=Interface] attribute HTMLElement? body;

readonly attribute HTMLHeadElement? head;

[SameObject] readonly attribute HTMLCollection images;

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/document-dir-property-expected.txt ('k') | no next file » | no next file with comments »