Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1420563006: SVG should respect overflow:visible even with border-radius (Closed)

Created:
5 years, 1 month ago by Shanmuga Pandi
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SVG should respect overflow:visible even with border-radius SVG should not push clip though it has border-radius, but with overflow:visible. BUG=530790 Committed: https://crrev.com/546a15be2fc46c9e69b612c17a8d3d9d13e83eb2 Cr-Commit-Position: refs/heads/master@{#360047}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixed nits #

Patch Set 3 : small nits #

Total comments: 6

Patch Set 4 : Align with review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -5 lines) Patch
A + third_party/WebKit/LayoutTests/svg/overflow/overflow-visible-with-border-radius.html View 1 2 3 1 chunk +6 lines, -3 lines 0 comments Download
A + third_party/WebKit/LayoutTests/svg/overflow/overflow-visible-with-border-radius-expected.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/ReplacedPainter.cpp View 1 2 3 3 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
rwlbuis
Just a few nits, once you fix them feel free to add other people for ...
5 years, 1 month ago (2015-11-09 19:07:09 UTC) #3
Shanmuga Pandi
Please review this . Thank you
5 years, 1 month ago (2015-11-16 07:45:13 UTC) #7
fs
https://codereview.chromium.org/1420563006/diff/40001/third_party/WebKit/LayoutTests/svg/overflow/overflow-visible-with-border-radius.html File third_party/WebKit/LayoutTests/svg/overflow/overflow-visible-with-border-radius.html (right): https://codereview.chromium.org/1420563006/diff/40001/third_party/WebKit/LayoutTests/svg/overflow/overflow-visible-with-border-radius.html#newcode3 third_party/WebKit/LayoutTests/svg/overflow/overflow-visible-with-border-radius.html:3: <head> Drop <html>, <head> and <body>. https://codereview.chromium.org/1420563006/diff/40001/third_party/WebKit/LayoutTests/svg/overflow/overflow-visible-with-border-radius.html#newcode19 third_party/WebKit/LayoutTests/svg/overflow/overflow-visible-with-border-radius.html:19: <svg ...
5 years, 1 month ago (2015-11-16 15:35:03 UTC) #8
Shanmuga Pandi
https://codereview.chromium.org/1420563006/diff/40001/third_party/WebKit/LayoutTests/svg/overflow/overflow-visible-with-border-radius.html File third_party/WebKit/LayoutTests/svg/overflow/overflow-visible-with-border-radius.html (right): https://codereview.chromium.org/1420563006/diff/40001/third_party/WebKit/LayoutTests/svg/overflow/overflow-visible-with-border-radius.html#newcode3 third_party/WebKit/LayoutTests/svg/overflow/overflow-visible-with-border-radius.html:3: <head> On 2015/11/16 15:35:03, fs wrote: > Drop <html>, ...
5 years, 1 month ago (2015-11-17 06:11:15 UTC) #9
fs
lgtm
5 years, 1 month ago (2015-11-17 08:59:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420563006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420563006/60001
5 years, 1 month ago (2015-11-17 09:04:37 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 1 month ago (2015-11-17 10:19:40 UTC) #13
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 10:20:52 UTC) #14
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/546a15be2fc46c9e69b612c17a8d3d9d13e83eb2
Cr-Commit-Position: refs/heads/master@{#360047}

Powered by Google App Engine
This is Rietveld 408576698