SVG should respect overflow:visible even with border-radius

third_party/WebKit/Source/core/paint/ReplacedPainter.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "core/paint/ReplacedPainter.h"
 
 #include "core/layout/LayoutReplaced.h"
 #include "core/layout/api/SelectionState.h"
+#include "core/layout/svg/LayoutSVGRoot.h"
 #include "core/paint/BoxPainter.h"
 #include "core/paint/LayoutObjectDrawingRecorder.h"
 #include "core/paint/ObjectPainter.h"
 #include "core/paint/PaintInfo.h"
 #include "core/paint/PaintLayer.h"
 #include "core/paint/RoundedInnerRectClipper.h"
 #include "wtf/Optional.h"
 
 namespace blink {
 
@@ skipping 32 matching lines @@
         if (m_layoutReplaced.selectionState() == SelectionNone)
             return;
 
     {
         Optional<RoundedInnerRectClipper> clipper;
         bool completelyClippedOut = false;
         if (m_layoutReplaced.style()->hasBorderRadius()) {
             if (borderRect.isEmpty()) {
                 completelyClippedOut = true;
             } else {
-                // Push a clip if we have a border radius, since we want to round the foreground content that gets painted.
-                FloatRoundedRect roundedInnerRect = m_layoutReplaced.style()->getRoundedInnerBorderFor(borderRect,
-                    LayoutRectOutsets(
-                        -(m_layoutReplaced.paddingTop() + m_layoutReplaced.borderTop()),
-                        -(m_layoutReplaced.paddingRight() + m_layoutReplaced.borderRight()),
-                        -(m_layoutReplaced.paddingBottom() + m_layoutReplaced.borderBottom()),
-                        -(m_layoutReplaced.paddingLeft() + m_layoutReplaced.borderLeft())),
-                    true, true);
+                if (!m_layoutReplaced.isSVGRoot() || toLayoutSVGRoot(&m_layoutReplaced)->shouldApplyViewportClip()) {

[fs, 2015/11/16 15:35:03]

Could you put this in a helper method, and then do "else if (...) {"?

[Shanmuga Pandi, 2015/11/17 06:11:15]

Done.

+                    // Push a clip if we have a border radius, since we want to round the foreground content that gets painted.
+                    FloatRoundedRect roundedInnerRect = m_layoutReplaced.style()->getRoundedInnerBorderFor(borderRect,
+                        LayoutRectOutsets(
+                            -(m_layoutReplaced.paddingTop() + m_layoutReplaced.borderTop()),
+                            -(m_layoutReplaced.paddingRight() + m_layoutReplaced.borderRight()),
+                            -(m_layoutReplaced.paddingBottom() + m_layoutReplaced.borderBottom()),
+                            -(m_layoutReplaced.paddingLeft() + m_layoutReplaced.borderLeft())),
+                        true, true);
 
-                clipper.emplace(m_layoutReplaced, paintInfo, borderRect, roundedInnerRect, ApplyToDisplayList);
+                    clipper.emplace(m_layoutReplaced, paintInfo, borderRect, roundedInnerRect, ApplyToDisplayList);
+                }
             }
         }
 
         if (!completelyClippedOut) {
             if (paintInfo.phase == PaintPhaseClippingMask) {
                 BoxPainter(m_layoutReplaced).paintClippingMask(paintInfo, adjustedPaintOffset);
             } else {
                 m_layoutReplaced.paintReplaced(paintInfo, adjustedPaintOffset);
             }
         }
     }
 
     // The selection tint never gets clipped by border-radius rounding, since we want it to run right up to the edges of
     // surrounding content.
     bool drawSelectionTint = paintInfo.phase == PaintPhaseForeground && m_layoutReplaced.selectionState() != SelectionNone && !paintInfo.isPrinting();
     if (drawSelectionTint && !LayoutObjectDrawingRecorder::useCachedDrawingIfPossible(*paintInfo.context, m_layoutReplaced, DisplayItem::SelectionTint, adjustedPaintOffset)) {
         LayoutRect selectionPaintingRect = m_layoutReplaced.localSelectionRect();
         selectionPaintingRect.moveBy(adjustedPaintOffset);
         IntRect selectionPaintingIntRect = pixelSnappedIntRect(selectionPaintingRect);
 
         LayoutObjectDrawingRecorder drawingRecorder(*paintInfo.context, m_layoutReplaced, DisplayItem::SelectionTint, selectionPaintingIntRect, adjustedPaintOffset);
         paintInfo.context->fillRect(selectionPaintingIntRect, m_layoutReplaced.selectionBackgroundColor());
     }
 }
 
 } // namespace blink