Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1420563002: dart2js cps: More precise rewrite for indexables. (Closed)

Created:
5 years, 2 months ago by asgerf
Modified:
5 years, 2 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: More precise rewrite for indexables. Strings were not sometimes not considered indexables because [subtype=String] is not reduced to [exact=JSString]. We now rewrite the index-set operator to direct access even when the receiver object is potentially null (but is otherwise a mutable indexable). BUG= R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/9e29d33563feaed5aa111ec5ce636dd76cf27024

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -5 lines) Patch
M pkg/compiler/lib/src/cps_ir/type_mask_system.dart View 3 chunks +14 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
asgerf
5 years, 2 months ago (2015-10-20 18:16:37 UTC) #2
sra1
lgtm
5 years, 2 months ago (2015-10-21 01:02:42 UTC) #3
asgerf
5 years, 2 months ago (2015-10-21 10:54:25 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
9e29d33563feaed5aa111ec5ce636dd76cf27024 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698