Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: pkg/compiler/lib/src/cps_ir/type_propagation.dart

Issue 1420563002: dart2js cps: More precise rewrite for indexables. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/type_mask_system.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/cps_ir/type_propagation.dart
diff --git a/pkg/compiler/lib/src/cps_ir/type_propagation.dart b/pkg/compiler/lib/src/cps_ir/type_propagation.dart
index 7fd2153184a842c4c8fcec1039c8b22f15ccc75e..4748a59621bc931528b63d1b7e8d45ce5417427c 100644
--- a/pkg/compiler/lib/src/cps_ir/type_propagation.dart
+++ b/pkg/compiler/lib/src/cps_ir/type_propagation.dart
@@ -1238,8 +1238,8 @@ class TransformingVisitor extends DeepRecursiveVisitor {
return true;
case '[]=':
- if (receiverValue.isNullable) return false;
- if (!typeSystem.isDefinitelyMutableIndexable(receiverValue.type)) {
+ if (!typeSystem.isDefinitelyMutableIndexable(receiverValue.type,
+ allowNull: true)) {
return false;
}
Primitive index = getDartArgument(node, 0);
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/type_mask_system.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698