Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1420533008: [Media Router] Set initial sink availability to available in MRMojoImpl. (Closed)

Created:
5 years, 1 month ago by imcheng
Modified:
5 years, 1 month ago
Reviewers:
mark a. foltz
CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, media-router+watch_chromium.org, viettrungluu+watch_chromium.org, posciak+watch_chromium.org, mcasas+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router] Set initial sink availability to available in MRMojoImpl. To be submitted after MR extension has picked up the change to send SinkAvailability updates. BUG=530702 Committed: https://crrev.com/62e8f2fa305568f855fb2e30834c20fab4891f1a Cr-Commit-Position: refs/heads/master@{#358748}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/media/router/media_router_mojo_impl.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/media/router/media_router_mojo_impl_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
imcheng
Mark: PTAL
5 years, 1 month ago (2015-11-04 02:01:07 UTC) #3
mark a. foltz
LGTM Please test with the current stable extension before submitting so as not to break ...
5 years, 1 month ago (2015-11-09 18:35:31 UTC) #4
imcheng
Tested on stable extension. Everything works except for one case (and it has to do ...
5 years, 1 month ago (2015-11-10 00:29:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420533008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420533008/20001
5 years, 1 month ago (2015-11-10 00:36:28 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 1 month ago (2015-11-10 02:01:14 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 02:02:14 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/62e8f2fa305568f855fb2e30834c20fab4891f1a
Cr-Commit-Position: refs/heads/master@{#358748}

Powered by Google App Engine
This is Rietveld 408576698