Issue 1420503012: Partial revert of commit c6d8683 to fix a GN + Win/Clang build warning.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1420503012: Partial revert of commit c6d8683 to fix a GN + Win/Clang build warning. (Closed)

Created:
5 years, 1 month ago by Lei Zhang

Modified:
5 years, 1 month ago

Reviewers:
Nico

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium@master

Target Ref:
refs/heads/master

Visibility:
Public.

Total comments: 1

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	BUILD.gn	View		1 chunk	+3 lines, -1 line	1 comment	Download

Total messages: 5 (0 generated)

Lei Zhang

Committed patchset #1 (id:1) manually as f7a8b34f520f1d4892f009700972ab2995ed2681 (presubmit successful).

5 years, 1 month ago (2015-10-27 00:00:49 UTC) #2

Nico

thanks! sounds like this is broken on the xfa branch too. https://codereview.chromium.org/1420503012/diff/1/BUILD.gn File BUILD.gn (right): ...

5 years, 1 month ago (2015-10-27 00:03:04 UTC) #3

Lei Zhang

On 2015/10/27 00:03:04, Nico wrote: > thanks! sounds like this is broken on the xfa ...

5 years, 1 month ago (2015-10-27 00:05:00 UTC) #4

Message was sent while issue was closed.

lgtm, thanks much!