BUILD.gn - Issue 1420503012: Partial revert of commit c6d8683 to fix a GN + Win/Clang build warning.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: BUILD.gn

Issue 1420503012: Partial revert of commit c6d8683 to fix a GN + Win/Clang build warning. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn

index a2ddbadd55e1f6ad790015f2c0dfb3cee0a3b79f..73028636e495b7f4af47662e968dc9d19bcbd972 100644

--- a/BUILD.gn

+++ b/BUILD.gn

@@ -554,9 +554,11 @@ static_library("fxge") {

configs -= [ "//build/config/compiler:chromium_code" ]

configs += [

- ":fxge_warnings",

":pdfium_config",

"//build/config/compiler:no_chromium_code",

+ # As of this writing, this needs to be last to suppress a -Wswitch warning.

+ # https://crbug.com/547906

Nico 2015/10/27 00:03:03 The usual comment is # Must be after no_chrom

+ ":fxge_warnings",

]

if (pdf_use_skia) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »