Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1420503011: GLES2CmdDecoder should resize GLSurface using GLSurface::Resize (Closed)

Created:
5 years, 1 month ago by jbauman
Modified:
5 years, 1 month ago
Reviewers:
sky, piman
CC:
chromium-reviews, ozone-reviews_chromium.org, darin-cc_chromium.org, jam, kalyank, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GLES2CmdDecoder should resize GLSurface using GLSurface::Resize A special resize callback is unnecessary because the decoder has access to the GLSurface and can call Resize on that. Committed: https://crrev.com/ce45e11f6759070f4f35f9a3f9d2ea33cb765c69 Cr-Commit-Position: refs/heads/master@{#357029}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Total comments: 1

Patch Set 7 : #

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -97 lines) Patch
M components/mus/gles2/command_buffer_driver.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/gles2/command_buffer_driver.cc View 1 2 3 4 5 6 2 chunks +0 lines, -6 lines 0 comments Download
M components/mus/gles2/command_buffer_local.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/gles2/command_buffer_local.cc View 1 2 3 4 5 6 2 chunks +0 lines, -6 lines 0 comments Download
M content/common/gpu/image_transport_surface.h View 2 3 4 5 6 7 2 chunks +0 lines, -2 lines 0 comments Download
M content/common/gpu/image_transport_surface.cc View 2 3 4 5 6 7 3 chunks +0 lines, -17 lines 0 comments Download
M content/common/gpu/image_transport_surface_overlay_mac.h View 1 2 3 4 5 6 2 chunks +1 line, -1 line 0 comments Download
M content/common/gpu/image_transport_surface_overlay_mac.mm View 1 2 3 4 5 6 1 chunk +3 lines, -2 lines 0 comments Download
M content/common/gpu/media/rendering_helper.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gl_surface_mock.h View 1 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.h View 1 chunk +0 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 4 chunks +5 lines, -14 lines 0 comments Download
M gpu/command_buffer/service/in_process_command_buffer.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/in_process_command_buffer.cc View 1 2 3 4 5 6 2 chunks +0 lines, -10 lines 0 comments Download
M ui/gl/gl_surface.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gl/gl_surface.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/gl/gl_surface_egl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/gl/gl_surface_egl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/gl/gl_surface_glx.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_surface_glx.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_surface_osmesa.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_surface_osmesa.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gl/gl_surface_ozone.cc View 1 2 3 4 5 6 6 chunks +12 lines, -9 lines 0 comments Download
M ui/gl/gl_surface_x11.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M ui/ozone/demo/gl_renderer.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (8 generated)
jbauman
5 years, 1 month ago (2015-10-27 20:52:46 UTC) #4
piman
LGTM overall, but one thing. https://codereview.chromium.org/1420503011/diff/90001/content/common/gpu/image_transport_surface_android.cc File content/common/gpu/image_transport_surface_android.cc (right): https://codereview.chromium.org/1420503011/diff/90001/content/common/gpu/image_transport_surface_android.cc#newcode30 content/common/gpu/image_transport_surface_android.cc:30: GpuMemoryManager::kScheduleManageNow); So, because of ...
5 years, 1 month ago (2015-10-27 23:11:47 UTC) #5
jbauman
sky@: OWNERS review of components/mus.
5 years, 1 month ago (2015-10-28 21:29:17 UTC) #7
sky
LGTM
5 years, 1 month ago (2015-10-29 15:23:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420503011/130001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420503011/130001
5 years, 1 month ago (2015-10-29 20:34:42 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/123909)
5 years, 1 month ago (2015-10-29 22:01:42 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420503011/130001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420503011/130001
5 years, 1 month ago (2015-10-30 02:02:24 UTC) #15
commit-bot: I haz the power
Committed patchset #8 (id:130001)
5 years, 1 month ago (2015-10-30 02:34:05 UTC) #16
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 02:34:51 UTC) #17
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/ce45e11f6759070f4f35f9a3f9d2ea33cb765c69
Cr-Commit-Position: refs/heads/master@{#357029}

Powered by Google App Engine
This is Rietveld 408576698