Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1420433004: Move selector and arguments descriptor into MegamorphicCache. (Closed)

Created:
5 years, 2 months ago by rmacnak
Modified:
5 years, 2 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move selector and arguments descriptor into MegamorphicCache. Towards making call sites swappable between ICs and MegamorphicCaches. R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/9de6b3be0af2045213ee6e61df088954eb875509

Patch Set 1 #

Total comments: 2

Patch Set 2 : parne #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -26 lines) Patch
M runtime/observatory/lib/src/elements/megamorphiccache_view.html View 1 chunk +12 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/service_ref.html View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 3 chunks +5 lines, -0 lines 0 comments Download
M runtime/vm/megamorphic_cache_table.h View 1 chunk +0 lines, -8 lines 0 comments Download
M runtime/vm/megamorphic_cache_table.cc View 1 2 chunks +10 lines, -13 lines 0 comments Download
M runtime/vm/object.h View 3 chunks +18 lines, -1 line 0 comments Download
M runtime/vm/object.cc View 1 5 chunks +32 lines, -1 line 0 comments Download
M runtime/vm/precompiler.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M runtime/vm/raw_object.h View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
rmacnak
5 years, 2 months ago (2015-10-20 17:15:14 UTC) #2
srdjan
lgtm m https://codereview.chromium.org/1420433004/diff/1/runtime/vm/megamorphic_cache_table.cc File runtime/vm/megamorphic_cache_table.cc (right): https://codereview.chromium.org/1420433004/diff/1/runtime/vm/megamorphic_cache_table.cc#newcode32 runtime/vm/megamorphic_cache_table.cc:32: cache.arguments_descriptor() == descriptor.raw()) { Add parens
5 years, 2 months ago (2015-10-20 20:17:07 UTC) #3
rmacnak
https://codereview.chromium.org/1420433004/diff/1/runtime/vm/megamorphic_cache_table.cc File runtime/vm/megamorphic_cache_table.cc (right): https://codereview.chromium.org/1420433004/diff/1/runtime/vm/megamorphic_cache_table.cc#newcode32 runtime/vm/megamorphic_cache_table.cc:32: cache.arguments_descriptor() == descriptor.raw()) { On 2015/10/20 20:17:07, srdjan wrote: ...
5 years, 2 months ago (2015-10-20 20:44:06 UTC) #4
rmacnak
5 years, 2 months ago (2015-10-20 20:44:25 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
9de6b3be0af2045213ee6e61df088954eb875509 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698