Move selector and arguments descriptor into MegamorphicCache.

runtime/vm/megamorphic_cache_table.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/megamorphic_cache_table.h"
 
 #include <stdlib.h>
 #include "vm/object.h"
 #include "vm/object_store.h"
 #include "vm/stub_code.h"
 #include "vm/symbols.h"
 
 namespace dart {
 
 RawMegamorphicCache* MegamorphicCacheTable::Lookup(Isolate* isolate,
                                                    const String& name,
                                                    const Array& descriptor) {
   ASSERT(name.IsSymbol());
   // TODO(rmacnak): ASSERT(descriptor.IsCanonical());
 
   // TODO(rmacnak): Make a proper hashtable a la symbol table.
   GrowableObjectArray& table = GrowableObjectArray::Handle(
       isolate->object_store()->megamorphic_cache_table());
+  MegamorphicCache& cache = MegamorphicCache::Handle();
   if (table.IsNull()) {
     table = GrowableObjectArray::New(Heap::kOld);
-    ASSERT((table.Length() % kEntrySize) == 0);
     isolate->object_store()->set_megamorphic_cache_table(table);
   } else {
-    for (intptr_t i = 0; i < table.Length(); i += kEntrySize) {
-      if ((table.At(i + kEntryNameOffset) == name.raw()) &&
-          (table.At(i + kEntryDescriptorOffset) == descriptor.raw())) {
-        return MegamorphicCache::RawCast(table.At(i + kEntryCacheOffset));
+    for (intptr_t i = 0; i < table.Length(); i++) {
+      cache ^= table.At(i);
+      if (cache.target_name() == name.raw() &&
+          cache.arguments_descriptor() == descriptor.raw()) {

[srdjan, 2015/10/20 20:17:07]

Add parens

[rmacnak, 2015/10/20 20:44:06]

Done.

+        return cache.raw();
       }
     }
   }
 
-  const MegamorphicCache& cache =
-      MegamorphicCache::Handle(MegamorphicCache::New());
-  table.Add(name, Heap::kOld);
-  table.Add(descriptor, Heap::kOld);
+  cache = MegamorphicCache::New(name, descriptor);
   table.Add(cache, Heap::kOld);
-  ASSERT((table.Length() % kEntrySize) == 0);
   return cache.raw();
 }
 
 
 RawFunction* MegamorphicCacheTable::miss_handler(Isolate* isolate) {
   ASSERT(isolate->object_store()->megamorphic_miss_function() !=
          Function::null());
   return isolate->object_store()->megamorphic_miss_function();
 }
 
@@ skipping 29 matching lines @@
 
 
 void MegamorphicCacheTable::PrintSizes(Isolate* isolate) {
   StackZone zone(Thread::Current());
   intptr_t size = 0;
   MegamorphicCache& cache = MegamorphicCache::Handle();
   Array& buckets = Array::Handle();
   const GrowableObjectArray& table = GrowableObjectArray::Handle(
       isolate->object_store()->megamorphic_cache_table());
   if (table.IsNull()) return;
-  for (intptr_t i = 0; i < table.Length(); i += kEntrySize) {
-    cache ^= table.At(i + kEntryCacheOffset);
+  for (intptr_t i = 0; i < table.Length(); i++) {
+    cache ^= table.At(i);
     buckets = cache.buckets();
     size += MegamorphicCache::InstanceSize();
     size += Array::InstanceSize(buckets.Length());
   }
   OS::Print("%" Pd " megamorphic caches using %" Pd "KB.\n",
-            table.Length() / kEntrySize, size / 1024);
+            table.Length(), size / 1024);
 }
 
 }  // namespace dart