Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Unified Diff: test/cctest/heap/test-heap.cc

Issue 1420423009: [heap] Black allocation. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/heap/test-heap.cc
diff --git a/test/cctest/heap/test-heap.cc b/test/cctest/heap/test-heap.cc
index 2939c988d529588da72669447f6653919639df26..bbdba61b1b5ab30195d160a4ed32df23d86412ac 100644
--- a/test/cctest/heap/test-heap.cc
+++ b/test/cctest/heap/test-heap.cc
@@ -4941,6 +4941,7 @@ TEST(NoWeakHashTableLeakWithIncrementalMarking) {
}
heap->CollectAllGarbage();
}
+ heap->CollectAllGarbage();
Michael Lippautz 2016/02/04 17:59:51 Please also add comment for black allocated object
Hannes Payer (out of office) 2016/02/06 08:50:16 Note that I changed the test case.
int elements = 0;
if (heap->weak_object_to_code_table()->IsHashTable()) {
WeakHashTable* t = WeakHashTable::cast(heap->weak_object_to_code_table());
@@ -5459,6 +5460,9 @@ TEST(WeakCellsWithIncrementalMarking) {
CHECK(weak_cell->value()->IsFixedArray());
weak_cells[i] = inner_scope.CloseAndEscape(weak_cell);
}
+ // Call collect all twice to make sure that we also cleared
+ // weak cells that were allocated on black pages.
+ heap->CollectAllGarbage();
heap->CollectAllGarbage();
CHECK_EQ(*survivor, weak_cells[0]->value());
for (int i = 1; i < N; i++) {
« src/heap/spaces.h ('K') | « src/objects-inl.h ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698