Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(813)

Issue 1420423009: [heap] Black allocation. (Closed)

Created:
5 years, 1 month ago by Hannes Payer (out of office)
Modified:
4 years, 9 months ago
Reviewers:
Michael Lippautz, ulan, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Black allocation. When black allocation is active, all objects allocated in old space are allocated black. Important: With that change, you cannot assume anymore that new objects are white right after their allocation. Currently, black allocation is enabled when incremental marking is started. This feature can be turned off via flag: --noblack-allocation BUG=chromium:561449 LOG=n Committed: https://crrev.com/ad51e8b1e8d6b28604ec9c9569f49f5c29f868e6 Cr-Commit-Position: refs/heads/master@{#34743}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Patch Set 11 : #

Patch Set 12 : #

Patch Set 13 : #

Patch Set 14 : #

Patch Set 15 : #

Patch Set 16 : #

Patch Set 17 : #

Patch Set 18 : #

Patch Set 19 : #

Patch Set 20 : #

Total comments: 20

Patch Set 21 : #

Patch Set 22 : #

Total comments: 10

Patch Set 23 : #

Patch Set 24 : #

Patch Set 25 : #

Patch Set 26 : #

Patch Set 27 : #

Patch Set 28 : #

Patch Set 29 : #

Patch Set 30 : #

Patch Set 31 : #

Total comments: 4

Patch Set 32 : #

Patch Set 33 : #

Patch Set 34 : #

Patch Set 35 : #

Total comments: 1

Patch Set 36 : #

Patch Set 37 : #

Patch Set 38 : #

Patch Set 39 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+399 lines, -154 lines) Patch
M src/debug/debug.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 1 chunk +1 line, -0 lines 0 comments Download
M src/flag-definitions.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/heap.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 6 chunks +20 lines, -18 lines 0 comments Download
M src/heap/heap.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 12 chunks +71 lines, -23 lines 0 comments Download
M src/heap/heap-inl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 1 chunk +5 lines, -3 lines 0 comments Download
M src/heap/incremental-marking.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 4 chunks +10 lines, -1 line 0 comments Download
M src/heap/incremental-marking.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 7 chunks +50 lines, -1 line 0 comments Download
M src/heap/mark-compact.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 4 chunks +84 lines, -69 lines 0 comments Download
M src/heap/mark-compact.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 15 chunks +83 lines, -20 lines 0 comments Download
M src/heap/mark-compact-inl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 2 chunks +13 lines, -0 lines 0 comments Download
M src/heap/remembered-set.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap/scavenger.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 2 chunks +4 lines, -2 lines 0 comments Download
M src/heap/spaces.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 4 chunks +11 lines, -1 line 0 comments Download
M src/heap/spaces.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 3 chunks +17 lines, -2 lines 0 comments Download
M src/heap/spaces-inl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 2 chunks +6 lines, -0 lines 0 comments Download
M src/objects.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 2 chunks +6 lines, -7 lines 0 comments Download
M src/objects-inl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 1 chunk +5 lines, -2 lines 0 comments Download
M src/snapshot/deserializer.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 2 chunks +3 lines, -0 lines 0 comments Download
M src/transitions.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/heap/test-heap.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 2 chunks +5 lines, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 26 (11 generated)
Hannes Payer (out of office)
4 years, 10 months ago (2016-02-04 16:37:06 UTC) #5
Michael Lippautz
Two questions, otherwise just nits. Well spread out over the whole code base ;) https://codereview.chromium.org/1420423009/diff/380001/src/heap/heap.cc ...
4 years, 10 months ago (2016-02-04 17:59:51 UTC) #6
Hannes Payer (out of office)
https://codereview.chromium.org/1420423009/diff/380001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1420423009/diff/380001/src/heap/heap.cc#newcode3376 src/heap/heap.cc:3376: // We have to iterate over over the object ...
4 years, 10 months ago (2016-02-06 08:50:16 UTC) #7
ulan
Exciting stuff! High level comments: https://codereview.chromium.org/1420423009/diff/420001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1420423009/diff/420001/src/heap/heap.cc#newcode1181 src/heap/heap.cc:1181: perform_gc = true; How ...
4 years, 10 months ago (2016-02-10 10:27:39 UTC) #8
Hannes Payer (out of office)
https://codereview.chromium.org/1420423009/diff/420001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1420423009/diff/420001/src/heap/heap.cc#newcode1181 src/heap/heap.cc:1181: perform_gc = true; On 2016/02/10 10:27:39, ulan wrote: > ...
4 years, 10 months ago (2016-02-11 18:18:07 UTC) #9
ulan
Looks good! How do we ensure that JSWeakCollections and ArrayBuffers are not pretenured? https://codereview.chromium.org/1420423009/diff/590001/src/heap/heap.cc File ...
4 years, 10 months ago (2016-02-16 10:38:09 UTC) #10
Hannes Payer (out of office)
https://codereview.chromium.org/1420423009/diff/590001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1420423009/diff/590001/src/heap/heap.cc#newcode4583 src/heap/heap.cc:4583: // TODO(hpayer): Right now we are also going to ...
4 years, 9 months ago (2016-03-11 14:20:48 UTC) #11
Hannes Payer (out of office)
4 years, 9 months ago (2016-03-11 14:21:10 UTC) #13
Yang
On 2016/03/11 14:21:10, Hannes Payer - slow wrote: serializer lgtm, if RegisterReservationsForBlackAllocation does what I ...
4 years, 9 months ago (2016-03-11 14:24:08 UTC) #14
Hannes Payer (out of office)
https://codereview.chromium.org/1420423009/diff/670001/src/heap/mark-compact-inl.h File src/heap/mark-compact-inl.h (right): https://codereview.chromium.org/1420423009/diff/670001/src/heap/mark-compact-inl.h#newcode146 src/heap/mark-compact-inl.h:146: if (T == kGreyObjectsOnBlackPage) { We need that when ...
4 years, 9 months ago (2016-03-11 15:49:36 UTC) #15
ulan
LGTM
4 years, 9 months ago (2016-03-14 09:56:57 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420423009/750001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420423009/750001
4 years, 9 months ago (2016-03-14 14:00:20 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420423009/750001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420423009/750001
4 years, 9 months ago (2016-03-14 14:01:21 UTC) #22
commit-bot: I haz the power
Failed to apply the patch.
4 years, 9 months ago (2016-03-14 14:02:29 UTC) #24
commit-bot: I haz the power
4 years, 9 months ago (2016-03-14 14:03:07 UTC) #26
Message was sent while issue was closed.
Patchset 39 (id:??) landed as
https://crrev.com/ad51e8b1e8d6b28604ec9c9569f49f5c29f868e6
Cr-Commit-Position: refs/heads/master@{#34743}

Powered by Google App Engine
This is Rietveld 408576698