Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1420423002: Fix gl caps for mixed sample support (Closed)

Created:
5 years, 1 month ago by egdaniel
Modified:
5 years, 1 month ago
Reviewers:
bsalomon
CC:
reviews_skia.org, Chris Dalton
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix gl caps for mixed sample support The dependencies between glsl caps and some gl ones were more complex than I had thought with original change especially in regards to mix samples, advanced blends, and similar features. This changes simply reverts back to the original order of setting the caps so it should fix all perf issues that were seen in the X1 BUG=skia:4505 Committed: https://skia.googlesource.com/skia/+/05ded891272772d43acc16345b2f90a4560df090

Patch Set 1 #

Patch Set 2 : Add more comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -52 lines) Patch
M src/gpu/gl/GrGLCaps.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 6 chunks +52 lines, -51 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
egdaniel
5 years, 1 month ago (2015-10-26 13:51:28 UTC) #3
bsalomon
lgtm, but it'd be good to document the dependencies somewhere.
5 years, 1 month ago (2015-10-26 14:01:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420423002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420423002/20001
5 years, 1 month ago (2015-10-26 14:25:23 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 14:38:07 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/05ded891272772d43acc16345b2f90a4560df090

Powered by Google App Engine
This is Rietveld 408576698