Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1420413002: Assume that ReportFailedAccessCheck always schedules an exception. (Closed)

Created:
5 years, 1 month ago by neis
Modified:
5 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Assume that ReportFailedAccessCheck always schedules an exception. R=verwaest@chromium.org BUG= Committed: https://crrev.com/effe76ad25c23bfd8be447930bd5d5126b1c9096 Cr-Commit-Position: refs/heads/master@{#31560}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -13 lines) Patch
M src/builtins.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.cc View 11 chunks +10 lines, -13 lines 0 comments Download
M src/runtime/runtime-classes.cc View 4 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
neis
5 years, 1 month ago (2015-10-26 11:53:36 UTC) #1
Toon Verwaest
awesome. lgtm
5 years, 1 month ago (2015-10-26 11:55:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420413002/1
5 years, 1 month ago (2015-10-26 11:56:31 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-26 12:30:14 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/effe76ad25c23bfd8be447930bd5d5126b1c9096 Cr-Commit-Position: refs/heads/master@{#31560}
5 years, 1 month ago (2015-10-26 12:30:47 UTC) #6
Michael Achenbach
5 years, 1 month ago (2015-10-26 14:53:49 UTC) #7
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1424703002/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Crashes in layout tests:
http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/buil...

#
# Fatal error in , line 0
# unreachable code
#.

Powered by Google App Engine
This is Rietveld 408576698