Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Unified Diff: src/runtime/runtime-classes.cc

Issue 1420413002: Assume that ReportFailedAccessCheck always schedules an exception. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/runtime/runtime-classes.cc
diff --git a/src/runtime/runtime-classes.cc b/src/runtime/runtime-classes.cc
index 53583086121b130c0211d67d680188821b4da90a..4c0627e168389e5ce834449e7bfbf1cf2881b05d 100644
--- a/src/runtime/runtime-classes.cc
+++ b/src/runtime/runtime-classes.cc
@@ -272,6 +272,7 @@ static MaybeHandle<Object> LoadFromSuper(Isolate* isolate,
!isolate->MayAccess(handle(isolate->context()), home_object)) {
isolate->ReportFailedAccessCheck(home_object);
RETURN_EXCEPTION_IF_SCHEDULED_EXCEPTION(isolate, Object);
+ UNREACHABLE();
}
PrototypeIterator iter(isolate, home_object);
@@ -297,6 +298,7 @@ static MaybeHandle<Object> LoadElementFromSuper(Isolate* isolate,
!isolate->MayAccess(handle(isolate->context()), home_object)) {
isolate->ReportFailedAccessCheck(home_object);
RETURN_EXCEPTION_IF_SCHEDULED_EXCEPTION(isolate, Object);
+ UNREACHABLE();
}
PrototypeIterator iter(isolate, home_object);
@@ -374,6 +376,7 @@ static Object* StoreToSuper(Isolate* isolate, Handle<JSObject> home_object,
!isolate->MayAccess(handle(isolate->context()), home_object)) {
isolate->ReportFailedAccessCheck(home_object);
RETURN_FAILURE_IF_SCHEDULED_EXCEPTION(isolate);
+ UNREACHABLE();
}
PrototypeIterator iter(isolate, home_object);
@@ -399,6 +402,7 @@ static Object* StoreElementToSuper(Isolate* isolate,
!isolate->MayAccess(handle(isolate->context()), home_object)) {
isolate->ReportFailedAccessCheck(home_object);
RETURN_FAILURE_IF_SCHEDULED_EXCEPTION(isolate);
+ UNREACHABLE();
}
PrototypeIterator iter(isolate, home_object);
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698