Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1420303002: Remove support for intrinsic and min-intrinsic (Closed)

Created:
5 years, 2 months ago by cbiesinger
Modified:
5 years, 1 month ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, krit, eae+blinkwatch, Eric Willigers, f(malita), fs, gyuyoung2, jchaffraix+rendering, jfernandez, kouhei+svg_chromium.org, leviw+renderwatch, pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, Manuel Rego, rjwright, rwlbuis, Stephen Chennney, shans, svillar, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove support for intrinsic and min-intrinsic Intent to remove: https://groups.google.com/a/chromium.org/d/topic/blink-dev/R9JzO74jYvI/discussion R=esprehn@chromium.org,leviw@chromium.org BUG=475104 Committed: https://crrev.com/93b39dfe7b909ce376935f30195e433490a86b01 Cr-Commit-Position: refs/heads/master@{#356110}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -89 lines) Patch
M third_party/WebKit/LayoutTests/fast/css-grid-layout/percent-track-breadths-regarding-container-size.html View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/percent-track-breadths-regarding-container-size-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/deprecated-flex-box-zero-width-intrinsic-max-width.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/deprecated-flex-box-zero-width-intrinsic-max-width-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSValueKeywords.in View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 chunk +1 line, -7 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp View 1 chunk +0 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp View 2 chunks +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGLengthContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/Length.h View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/LengthFunctions.cpp View 3 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420303002/1
5 years, 2 months ago (2015-10-23 21:07:01 UTC) #2
cbiesinger
5 years, 2 months ago (2015-10-23 21:55:29 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-24 00:14:24 UTC) #5
leviw_travelin_and_unemployed
Woot! LGTM!
5 years, 1 month ago (2015-10-26 18:36:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420303002/1
5 years, 1 month ago (2015-10-26 19:00:40 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-26 20:31:13 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 20:32:12 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/93b39dfe7b909ce376935f30195e433490a86b01
Cr-Commit-Position: refs/heads/master@{#356110}

Powered by Google App Engine
This is Rietveld 408576698