Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1420263002: Remove some dead code in SVG "mixins" (Closed)

Created:
5 years, 2 months ago by fs
Modified:
5 years, 2 months ago
Reviewers:
pdr.
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove some dead code in SVG "mixins" addSupportedAttributes() is no longer used (handled by the property map). Ditto for SVGFitToViewBox::parseAttribute and SVGTests::parseAttribute. Also drop the Document& to SVGTests::isValid since it isn't used. Committed: https://crrev.com/fc76b7e7f854c3791e683f3c9e81d27d9812be78 Cr-Commit-Position: refs/heads/master@{#355842}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -76 lines) Patch
M third_party/WebKit/Source/core/svg/SVGAnimationElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGCursorElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFitToViewBox.h View 2 chunks +0 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFitToViewBox.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGGraphicsElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGMaskElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPatternElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGSVGElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTests.h View 2 chunks +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTests.cpp View 3 chunks +1 line, -28 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGURIReference.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGURIReference.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGUseElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGZoomAndPan.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGZoomAndPan.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
fs
5 years, 2 months ago (2015-10-23 17:47:06 UTC) #2
pdr.
Mixin? Mixout LGTM
5 years, 2 months ago (2015-10-23 18:26:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420263002/1
5 years, 2 months ago (2015-10-23 18:27:05 UTC) #5
fs
On 2015/10/23 at 18:26:45, pdr wrote: > Mixin? Mixout > https://s-media-cache-ak0.pinimg.com/736x/48/ea/0a/48ea0a162a6dc45be3bcf184e6079f99.jpg
5 years, 2 months ago (2015-10-23 18:31:44 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-23 18:45:40 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 18:48:10 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/fc76b7e7f854c3791e683f3c9e81d27d9812be78
Cr-Commit-Position: refs/heads/master@{#355842}

Powered by Google App Engine
This is Rietveld 408576698