Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(763)

Unified Diff: third_party/WebKit/Source/core/svg/SVGTests.cpp

Issue 1420263002: Remove some dead code in SVG "mixins" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGTests.h ('k') | third_party/WebKit/Source/core/svg/SVGURIReference.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/svg/SVGTests.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGTests.cpp b/third_party/WebKit/Source/core/svg/SVGTests.cpp
index 2458e44275c6744d21b2684adfec0dfe25ee6d27..dd4cc342aa3cdd90a1767e6dc1287951719f8195 100644
--- a/third_party/WebKit/Source/core/svg/SVGTests.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGTests.cpp
@@ -46,7 +46,7 @@ DEFINE_TRACE(SVGTests)
visitor->trace(m_systemLanguage);
}
-bool SVGTests::isValid(Document& document) const
+bool SVGTests::isValid() const
{
// No need to check requiredFeatures since hasFeature always returns true.
@@ -71,26 +71,6 @@ bool SVGTests::isValid(Document& document) const
return true;
}
-bool SVGTests::parseAttribute(const QualifiedName& name, const AtomicString& value)
-{
- // FIXME: Should handle exceptions here.
- // This is safe as of now, as the current impl of SVGStringList::setValueAsString never fails.
- SVGParsingError parseError = NoError;
-
- if (name == SVGNames::requiredFeaturesAttr)
- m_requiredFeatures->setBaseValueAsString(value, parseError);
- else if (name == SVGNames::requiredExtensionsAttr)
- m_requiredExtensions->setBaseValueAsString(value, parseError);
- else if (name == SVGNames::systemLanguageAttr)
- m_systemLanguage->setBaseValueAsString(value, parseError);
- else
- return false;
-
- ASSERT(parseError == NoError);
-
- return true;
-}
-
bool SVGTests::isKnownAttribute(const QualifiedName& attrName)
{
return attrName == SVGNames::requiredFeaturesAttr
@@ -98,11 +78,4 @@ bool SVGTests::isKnownAttribute(const QualifiedName& attrName)
|| attrName == SVGNames::systemLanguageAttr;
}
-void SVGTests::addSupportedAttributes(HashSet<QualifiedName>& supportedAttributes)
-{
- supportedAttributes.add(SVGNames::requiredFeaturesAttr);
- supportedAttributes.add(SVGNames::requiredExtensionsAttr);
- supportedAttributes.add(SVGNames::systemLanguageAttr);
-}
-
}
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGTests.h ('k') | third_party/WebKit/Source/core/svg/SVGURIReference.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698