Issue 1420103002: Merge to XFA: Remove unused error variable from CFX_Font::AdjustMMParams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1420103002: Merge to XFA: Remove unused error variable from CFX_Font::AdjustMMParams (Closed)

Created:
5 years, 2 months ago by Oliver Chang

Modified:
5 years, 2 months ago

Reviewers:
Lei Zhang, Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Remove unused error variable from CFX_Font::AdjustMMParams Also fixes a potential memory leak. R=tsepez@chromium.org, thestig@chromium.org BUG=pdfium:156 Review URL: https://codereview.chromium.org/1409973003 . (cherry picked from commit de49cf173d12fe7a462168e2bf6c44971d7d28f8) Committed: https://pdfium.googlesource.com/pdfium/+/2bc980424d23d83e0d4b57b248789232709e07b8

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
	M	core/src/fxge/ge/fx_ge_text.cpp	View		1 chunk	+5 lines, -4 lines	0 comments	Download

Total messages: 4 (0 generated)

Tom Sepez

If the merge was clean, you can TBR with a comment saying "Clean merge", otherwise ...

5 years, 2 months ago (2015-10-22 18:18:04 UTC) #2

Oliver Chang

On 2015/10/22 18:18:04, Tom Sepez wrote: > If the merge was clean, you can TBR ...

5 years, 2 months ago (2015-10-22 18:20:10 UTC) #3

Oliver Chang

5 years, 2 months ago (2015-10-22 18:20:26 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2bc980424d23d83e0d4b57b248789232709e07b8 (presubmit successful).