Remove unused error variable from CFX_Font::AdjustMMParams

Remove unused error variable from CFX_Font::AdjustMMParams

Also fixes a potential memory leak.

R=tsepez@chromium.org, thestig@chromium.org
BUG=pdfium:156
Committed: https://pdfium.googlesource.com/pdfium/+/de49cf173d12fe7a462168e2bf6c44971d7d28f8

[Oliver Chang, 2015-10-22 17:56:08]

ptal, not sure if it's worth rewriting the whole method to make the failure
cases more explicit.

[Tom Sepez, 2015-10-22 17:56:48]

lgtm

[Oliver Chang, 2015-10-22 18:03:45]

Committed patchset #1 (id:1) manually as
de49cf173d12fe7a462168e2bf6c44971d7d28f8 (presubmit successful).

[Lei Zhang, 2015-10-22 18:53:40]

lgtm for now, but...

https://codereview.chromium.org/1409973003/diff/1/core/src/fxge/ge/fx_ge_text...
File core/src/fxge/ge/fx_ge_text.cpp (left):

https://codereview.chromium.org/1409973003/diff/1/core/src/fxge/ge/fx_ge_text...
core/src/fxge/ge/fx_ge_text.cpp:1404: int error =
FXFT_Set_MM_Design_Coordinates(m_Face, 2, coords);
Uh, we had plans to actually check |error|. See
https://code.google.com/p/pdfium/issues/detail?id=156 , which I never got around
to fixing.

[Oliver Chang, 2015-10-22 18:58:55]

https://codereview.chromium.org/1409973003/diff/1/core/src/fxge/ge/fx_ge_text...
File core/src/fxge/ge/fx_ge_text.cpp (left):

https://codereview.chromium.org/1409973003/diff/1/core/src/fxge/ge/fx_ge_text...
core/src/fxge/ge/fx_ge_text.cpp:1404: int error =
FXFT_Set_MM_Design_Coordinates(m_Face, 2, coords);
On 2015/10/22 18:53:40, Lei Zhang wrote:
> Uh, we had plans to actually check |error|. See
> https://code.google.com/p/pdfium/issues/detail?id=156 , which I never got
around
> to fixing.

Sure, I wasn't sure if it was worth rewriting the logic in a way to do the
actual error checking here.