[GN] Allow spaces in output names and other substitutions.

[GN] Allow spaces in output names and other substitutions.

BUG=546894
Committed: https://crrev.com/987f4a5507faeaa0c35c6e550fa993c288dbdfb0
Cr-Commit-Position: refs/heads/master@{#356545}

[Bons, 2015-10-27 14:12:01]

andybons@chromium.org changed reviewers:
+ brettw@chromium.org, dpranke@chromium.org

[Bons, 2015-10-27 14:12:02]

This is just one step, since the build will fail due to non-escaped commands
generated by the solink tools in the Mac toolchain.

Any advice on how to approach that would be appreciated.

[Bons, 2015-10-27 14:12:59]

The CQ bit was checked by andybons@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-27 14:13:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1420043004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1420043004/20001

[commit-bot: I haz the power, 2015-10-27 15:03:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-27 15:03:42]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2015-10-27 22:35:52]

lgtm, I think.

[Dirk Pranke, 2015-10-27 22:37:23]

Description was changed from

==========
[GN] Allow spaces in output names and other substitutions.

BUG=546894
==========

to

==========
[GN] Allow spaces in output names and other substitutions.

BUG=546894
==========

[Dirk Pranke, 2015-10-27 22:41:14]

On 2015/10/27 14:12:02, Bons wrote:
> This is just one step, since the build will fail due to non-escaped commands
> generated by the solink tools in the Mac toolchain.
> 
> Any advice on how to approach that would be appreciated.

+mcgrathr ...

We're looking at replacing the solink (and alink) commands w/ calls to a python
wrapper;
possibly we might be able to handle the escaping in the wrapper as well?

Failing that, is there some way you can modify the command that gets written out
to 
use ESCAPE_NINJA_COMMAND or ESCAPE_NINJA_PREFORMATTED_COMMAND
and then combine that w/ adjusting the command strings in gcc_toolchain.gni as
needed?

[Roland McGrath, 2015-10-27 23:11:08]

On 2015/10/27 22:41:14, Dirk Pranke wrote:
> On 2015/10/27 14:12:02, Bons wrote:
> > This is just one step, since the build will fail due to non-escaped commands
> > generated by the solink tools in the Mac toolchain.
> > 
> > Any advice on how to approach that would be appreciated.
> 
> +mcgrathr ...
> 
> We're looking at replacing the solink (and alink) commands w/ calls to a
python
> wrapper;
> possibly we might be able to handle the escaping in the wrapper as well?

I don't see how you can really avoid gn/ninja quoting things properly, since it
has to produce a command like that gets through the sh parser.
Certainly using a Python script makes it easier to avoid additional layers of
sensitivity to spaces within arguments than constructing complex shell commands.
The existing //build/toolchain/mac/BUILD.gn code uses things like "foo \"$file\"
bar", which handles spaces in the value of $file if there is nothing else
magical in there (arguably it should be using "foo '$file' bar" instead, but
either way it doesn't handle all characters that the system allows in file
names).

Note that Mac does not use gcc_toolchain.gni (though a TODO comment says it
wants to).  I am only working on gcc_toolchain.gni, so what I'm doing is not
immediately useful to Mac.

[Dirk Pranke, 2015-10-27 23:32:19]

On 2015/10/27 23:11:08, Roland McGrath wrote:
> I don't see how you can really avoid gn/ninja quoting things properly, since
it
> has to produce a command like that gets through the sh parser.

Yeah, it all kinda depends on what the definition of "properly" is, of course.

Good point about mac not using gcc_toolchain.gni; I had forgotten that.

[Bons, 2015-10-28 13:35:46]

The CQ bit was checked by andybons@chromium.org

[commit-bot: I haz the power, 2015-10-28 13:35:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1420043004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1420043004/20001

[commit-bot: I haz the power, 2015-10-28 13:40:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-28 13:40:56]

Failed to apply the patch.

[commit-bot: I haz the power, 2015-10-28 13:41:39]

Patchset 2 (id:??) landed as
https://crrev.com/987f4a5507faeaa0c35c6e550fa993c288dbdfb0
Cr-Commit-Position: refs/heads/master@{#356545}