tools/gn/ninja_target_writer.h - Issue 1420043004: [GN] Allow spaces in output names and other substitutions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/ninja_target_writer.h

Issue 1420043004: [GN] Allow spaces in output names and other substitutions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/ninja_target_writer.h

diff --git a/tools/gn/ninja_target_writer.h b/tools/gn/ninja_target_writer.h

index 4598ae850d72693f555f91cef63e9956394e2df0..0248b0788d765a07deb390f986527fffd4db5a6d 100644

--- a/tools/gn/ninja_target_writer.h

+++ b/tools/gn/ninja_target_writer.h

@@ -9,6 +9,7 @@

#include "base/macros.h"

#include "tools/gn/path_output.h"

+#include "tools/gn/substitution_type.h"

class FileTemplate;

class OutputFile;

@@ -54,6 +55,7 @@ class NinjaTargetWriter {

private:

void WriteCopyRules();

+ void WriteEscapedSubstitution(SubstitutionType type);

DISALLOW_COPY_AND_ASSIGN(NinjaTargetWriter);

};

« no previous file with comments | « no previous file | tools/gn/ninja_target_writer.cc » ('j') | no next file with comments »