Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1075)

Unified Diff: chrome/browser/ui/webui/options/clear_browser_data_handler.h

Issue 1420013004: Polish the result communication and display of the browsing data counters. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nits. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/clear_browser_data_handler.h
diff --git a/chrome/browser/ui/webui/options/clear_browser_data_handler.h b/chrome/browser/ui/webui/options/clear_browser_data_handler.h
index 6737cb2fda3a52ae5fb6d15ddaf872c788099452..3f08e323176ec852494a13f1a4e0abed2b1a3c23 100644
--- a/chrome/browser/ui/webui/options/clear_browser_data_handler.h
+++ b/chrome/browser/ui/webui/options/clear_browser_data_handler.h
@@ -47,18 +47,11 @@ class ClearBrowserDataHandler : public OptionsPageUIHandler,
// Updates UI when the pref to allow clearing history changes.
virtual void OnBrowsingHistoryPrefChanged();
- // Adds a |counter| for browsing data. Its output will be displayed
- // in the dialog with the string |text_grd_id|.
- void AddCounter(scoped_ptr<BrowsingDataCounter> counter, int text_grd_id);
-
- // Updates the counter of the pref |pref_name| in the UI according
- // to a callback from a |BrowsingDataCounter| that specifies whether
- // the counting has |finished| and what the |count| is. The |count| will
- // be substituted into the string with the ID |text_grd_id|.
- void UpdateCounterText(const std::string& pref_name,
- int text_grd_id,
- bool finished,
- BrowsingDataCounter::ResultInt count);
+ // Adds a |counter| for browsing data.
+ void AddCounter(scoped_ptr<BrowsingDataCounter> counter);
+
+ // Updates a counter in the UI according to the |result|.
+ void UpdateCounterText(scoped_ptr<BrowsingDataCounter::Result> result);
// Implementation of SyncServiceObserver. Updates the support string at the
// bottom of the dialog.

Powered by Google App Engine
This is Rietveld 408576698