chrome/browser/browsing_data/passwords_counter_browsertest.cc - Issue 1420013004: Polish the result communication and display of the browsing data counters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data/passwords_counter_browsertest.cc

Issue 1420013004: Polish the result communication and display of the browsing data counters. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nits. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/browsing_data/history_counter_browsertest.cc ('k') | chrome/browser/ui/webui/options/clear_browser_data_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/browsing_data/passwords_counter_browsertest.cc

diff --git a/chrome/browser/browsing_data/passwords_counter_browsertest.cc b/chrome/browser/browsing_data/passwords_counter_browsertest.cc

index 4ef3fd9a0cf397271aa234dbcf5f371cbcef3feb..2d269027bb7efcca60908cd023008147831c205e 100644

--- a/chrome/browser/browsing_data/passwords_counter_browsertest.cc

+++ b/chrome/browser/browsing_data/passwords_counter_browsertest.cc

@@ -87,10 +87,15 @@ class PasswordsCounterTest : public InProcessBrowserTest,

return result_;

}

- void Callback(bool finished, BrowsingDataCounter::ResultInt count) {

- finished_ = finished;

- result_ = count;

- if (run_loop_ && finished)

+ void Callback(scoped_ptr<BrowsingDataCounter::Result> result) {

+ finished_ = result->Finished();

+ if (finished_) {

+ result_ = static_cast<BrowsingDataCounter::FinishedResult*>(

+ result.get())->Value();

+ }

+ if (run_loop_ && finished_)

run_loop_->Quit();

}