Issue 14200035: Rollback of r13728 in 3.17 branch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14200035: Rollback of r13728 in 3.17 branch. (Closed)

Created:
7 years, 8 months ago by Michael Starzinger

Modified:
7 years, 8 months ago

Reviewers:
rossberg, danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/3.17

Visibility:
Public.

Rollback of r13728 in 3.17 branch. Make __proto__ a foreign callback on Object.prototype. R=danno@chromium.org,rossberg@chromium.org BUG=v8:621, v8:1949, v8:2441 TEST=mjsunit,cctest,test262 Committed: http://code.google.com/p/v8/source/detail?r=14313

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+60 lines, -86 lines)			Patch
M	src/bootstrapper.cc	View	1 chunk	+3 lines, -19 lines	0 comments	Download
M	src/factory.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/factory.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/json-parser.h	View	2 chunks	+11 lines, -5 lines	0 comments	Download
M	src/objects.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/property.h	View	3 chunks	+16 lines, -2 lines	0 comments	Download
M	src/version.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-api.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	test/mjsunit/builtins.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/harmony/object-observe.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	test/mjsunit/harmony/proxies.js	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	test/mjsunit/json.js	View	1 chunk	+10 lines, -17 lines	0 comments	Download
D	test/mjsunit/regress/regress-2441.js	View	1 chunk	+0 lines, -31 lines	0 comments	Download
M	test/test262/test262.status	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Michael Starzinger

7 years, 8 months ago (2013-04-17 16:14:35 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r14313 (presubmit successful).