unittest/AssemblerX8664/GPRArith.cpp - Issue 1419903002: Subzero: Refactor x86 register definitions to use the alias mechanism.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: unittest/AssemblerX8664/GPRArith.cpp

Issue 1419903002: Subzero: Refactor x86 register definitions to use the alias mechanism. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Fix assembler unit tests. Fix register names. Code review changes. Rebase Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: unittest/AssemblerX8664/GPRArith.cpp

diff --git a/unittest/AssemblerX8664/GPRArith.cpp b/unittest/AssemblerX8664/GPRArith.cpp

index ee5c01c971025e58482ccd5a3b2c259c82c439ac..09f29f70dec456d84e393df0660660669d0ec178 100644

--- a/unittest/AssemblerX8664/GPRArith.cpp

+++ b/unittest/AssemblerX8664/GPRArith.cpp

@@ -41,7 +41,7 @@ TEST_F(AssemblerX8664Test, SetCC) {

__ mov(IceType_i32, Encoded_GPR_##Src1(), Immediate(Value1)); \

__ cmp(IceType_i32, Encoded_GPR_##Src0(), Encoded_GPR_##Src1()); \

__ mov(IceType_i32, Encoded_GPR_##Dest(), Immediate(0)); \

- __ setcc(Cond::Br_##C, RegX8664::getEncodedByteReg(Encoded_GPR_##Dest())); \

+ __ setcc(Cond::Br_##C, Encoded_Bytereg_##Dest()); \

__ setcc(Cond::Br_##C, dwordAddress(T0)); \

AssembledTest test = assemble(); \

@@ -92,6 +92,7 @@ TEST_F(AssemblerX8664Test, SetCC) {

TestImpl(r2, r3, r4);

TestImpl(r3, r4, r5);

TestImpl(r4, r5, r6);

+ TestImpl(r4, r6, r7);

TestImpl(r5, r6, r7);

TestImpl(r6, r7, r8);

TestImpl(r7, r8, r10);

@@ -1759,7 +1760,7 @@ TEST_F(AssemblerX8664Test, Bt) {

__ mov(IceType_i32, Encoded_GPR_##Dst(), Immediate(Value0)); \

__ mov(IceType_i32, Encoded_GPR_##Src(), Immediate(Value1)); \

__ bt(Encoded_GPR_##Dst(), Encoded_GPR_##Src()); \

- __ setcc(Cond::Br_b, ByteRegister::Encoded_Reg_al); \

+ __ setcc(Cond::Br_b, ByteRegister::Encoded_8_Reg_al); \

__ And(IceType_i32, Encoded_GPR_eax(), Immediate(0xFFu)); \

AssembledTest test = assemble(); \

« no previous file with comments | « unittest/AssemblerX8632/X87.cpp ('k') | unittest/AssemblerX8664/LowLevel.cpp » ('j') | no next file with comments »