unittest/AssemblerX8632/TestUtil.h - Issue 1419903002: Subzero: Refactor x86 register definitions to use the alias mechanism.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: unittest/AssemblerX8632/TestUtil.h

Issue 1419903002: Subzero: Refactor x86 register definitions to use the alias mechanism. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Fix assembler unit tests. Fix register names. Code review changes. Rebase Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: unittest/AssemblerX8632/TestUtil.h

diff --git a/unittest/AssemblerX8632/TestUtil.h b/unittest/AssemblerX8632/TestUtil.h

index c11868f64f4eb5484e940dc187ef3542107b06d4..6adf27b525125d06bc132e726c9905139b511f85 100644

--- a/unittest/AssemblerX8632/TestUtil.h

+++ b/unittest/AssemblerX8632/TestUtil.h

@@ -28,9 +28,9 @@ namespace Test {

class AssemblerX8632TestBase : public ::testing::Test {

protected:

using Address = AssemblerX8632::Traits::Address;

- using ByteRegister = AssemblerX8632::Traits::ByteRegister;

using Cond = AssemblerX8632::Traits::Cond;

using GPRRegister = AssemblerX8632::Traits::GPRRegister;

+ using ByteRegister = AssemblerX8632::Traits::ByteRegister;

using Label = ::Ice::X86Internal::Label;

using Traits = AssemblerX8632::Traits;

using XmmRegister = AssemblerX8632::Traits::XmmRegister;

« no previous file with comments | « unittest/AssemblerX8632/LowLevel.cpp ('k') | unittest/AssemblerX8632/X87.cpp » ('j') | no next file with comments »