unittest/AssemblerX8632/LowLevel.cpp - Issue 1419903002: Subzero: Refactor x86 register definitions to use the alias mechanism.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: unittest/AssemblerX8632/LowLevel.cpp

Issue 1419903002: Subzero: Refactor x86 register definitions to use the alias mechanism. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Fix assembler unit tests. Fix register names. Code review changes. Rebase Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: unittest/AssemblerX8632/LowLevel.cpp

diff --git a/unittest/AssemblerX8632/LowLevel.cpp b/unittest/AssemblerX8632/LowLevel.cpp

index 1f01e8e3b496a5075b3d08fc0f8436fc387324c9..a963da5a44c774f7d9e3c5c1bc377919244ce226 100644

--- a/unittest/AssemblerX8632/LowLevel.cpp

+++ b/unittest/AssemblerX8632/LowLevel.cpp

@@ -203,10 +203,10 @@ TEST_F(AssemblerX8632LowLevelTest, Cmp) {

"(" #Inst ", " #Base ", " #Index ", " #Scale ", " #Disp ", " #Imm \

", " #OpType ", " #ByteCountUntyped ", " #__VA_ARGS__ ")"; \

static constexpr uint8_t ByteCount = ByteCountUntyped; \

- __ Inst(IceType_##OpType, Address(GPRRegister::Encoded_Reg_##Base, \

- GPRRegister::Encoded_Reg_##Index, \

- Traits::TIMES_##Scale, Disp, \

- AssemblerFixup::NoFixup), \

+ __ Inst(IceType_##OpType, \

+ Address(GPRRegister::Encoded_Reg_##Base, \

+ GPRRegister::Encoded_Reg_##Index, Traits::TIMES_##Scale, \

+ Disp, AssemblerFixup::NoFixup), \

Immediate(Imm)); \

ASSERT_EQ(ByteCount, codeBytesSize()) << TestString; \

ASSERT_TRUE(verifyBytes<ByteCount>(codeBytes(), __VA_ARGS__)) \

@@ -221,10 +221,10 @@ TEST_F(AssemblerX8632LowLevelTest, Cmp) {

"(" #Inst ", " #Base ", " #Index ", " #Scale ", " #Disp ", " #Src \