extensions/browser/extension_prefs.h - Issue 1419823011: app_sorting() calls should go via ExtensionSystem intsead of prefs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/extension_prefs.h

Issue 1419823011: app_sorting() calls should go via ExtensionSystem intsead of prefs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes as per review comments. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/extension_prefs.h

diff --git a/extensions/browser/extension_prefs.h b/extensions/browser/extension_prefs.h

index 892dd742455357a3d6c352ca8eae1c894cc258df..b2a3dd6c2c31fa07cf0fa6427fa30b8b28900dd8 100644

--- a/extensions/browser/extension_prefs.h

+++ b/extensions/browser/extension_prefs.h

@@ -514,8 +514,6 @@ class ExtensionPrefs : public ExtensionScopedPrefs, public KeyedService {

PrefService* pref_service() const { return prefs_; }

// The underlying AppSorting.

- // TODO(treib,kalman): This should be private, and all callers should go

- // through the ExtensionSystem instead.

AppSorting* app_sorting() const;

// Schedules garbage collection of an extension's on-disk data on the next

« no previous file with comments | « chrome/browser/ui/webui/ntp/app_launcher_handler.cc ('k') | no next file » | no next file with comments »