Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: extensions/browser/extension_prefs.h

Issue 1419823011: app_sorting() calls should go via ExtensionSystem intsead of prefs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes as per review comments. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/webui/ntp/app_launcher_handler.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_BROWSER_EXTENSION_PREFS_H_ 5 #ifndef EXTENSIONS_BROWSER_EXTENSION_PREFS_H_
6 #define EXTENSIONS_BROWSER_EXTENSION_PREFS_H_ 6 #define EXTENSIONS_BROWSER_EXTENSION_PREFS_H_
7 7
8 #include <set> 8 #include <set>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 496 matching lines...) Expand 10 before | Expand all | Expand 10 after
507 void ClearLastLaunchTimes(); 507 void ClearLastLaunchTimes();
508 508
509 static void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry); 509 static void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry);
510 510
511 bool extensions_disabled() const { return extensions_disabled_; } 511 bool extensions_disabled() const { return extensions_disabled_; }
512 512
513 // The underlying PrefService. 513 // The underlying PrefService.
514 PrefService* pref_service() const { return prefs_; } 514 PrefService* pref_service() const { return prefs_; }
515 515
516 // The underlying AppSorting. 516 // The underlying AppSorting.
517 // TODO(treib,kalman): This should be private, and all callers should go
518 // through the ExtensionSystem instead.
519 AppSorting* app_sorting() const; 517 AppSorting* app_sorting() const;
520 518
521 // Schedules garbage collection of an extension's on-disk data on the next 519 // Schedules garbage collection of an extension's on-disk data on the next
522 // start of this ExtensionService. Applies only to extensions with isolated 520 // start of this ExtensionService. Applies only to extensions with isolated
523 // storage. 521 // storage.
524 void SetNeedsStorageGarbageCollection(bool value); 522 void SetNeedsStorageGarbageCollection(bool value);
525 bool NeedsStorageGarbageCollection() const; 523 bool NeedsStorageGarbageCollection() const;
526 524
527 // Used by AppWindowGeometryCache to persist its cache. These methods 525 // Used by AppWindowGeometryCache to persist its cache. These methods
528 // should not be called directly. 526 // should not be called directly.
(...skipping 175 matching lines...) Expand 10 before | Expand all | Expand 10 after
704 bool extensions_disabled_; 702 bool extensions_disabled_;
705 703
706 base::ObserverList<ExtensionPrefsObserver> observer_list_; 704 base::ObserverList<ExtensionPrefsObserver> observer_list_;
707 705
708 DISALLOW_COPY_AND_ASSIGN(ExtensionPrefs); 706 DISALLOW_COPY_AND_ASSIGN(ExtensionPrefs);
709 }; 707 };
710 708
711 } // namespace extensions 709 } // namespace extensions
712 710
713 #endif // EXTENSIONS_BROWSER_EXTENSION_PREFS_H_ 711 #endif // EXTENSIONS_BROWSER_EXTENSION_PREFS_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/webui/ntp/app_launcher_handler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698