chrome/browser/ui/app_list/extension_app_item.cc - Issue 1419823011: app_sorting() calls should go via ExtensionSystem intsead of prefs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/extension_app_item.cc

Issue 1419823011: app_sorting() calls should go via ExtensionSystem intsead of prefs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes as per review comments. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/test/integration/two_client_apps_sync_test.cc ('k') | chrome/browser/ui/app_list/extension_app_model_builder_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/app_list/extension_app_item.cc

diff --git a/chrome/browser/ui/app_list/extension_app_item.cc b/chrome/browser/ui/app_list/extension_app_item.cc

index 471182cfe7032a64d8c114e32afb71f1d5e0d073..6bd1bb408ae1d0add9e8d6a8e53030467c558c1f 100644

--- a/chrome/browser/ui/app_list/extension_app_item.cc

+++ b/chrome/browser/ui/app_list/extension_app_item.cc

@@ -19,6 +19,7 @@

#include "extensions/browser/app_sorting.h"

#include "extensions/browser/extension_prefs.h"

#include "extensions/browser/extension_registry.h"

+#include "extensions/browser/extension_system.h"

#include "extensions/common/extension.h"

#include "extensions/common/extension_icon_set.h"

#include "extensions/common/manifest_handlers/icons_handler.h"

@@ -101,7 +102,7 @@ class RoundedCornersImageSource : public gfx::CanvasImageSource {

};

extensions::AppSorting* GetAppSorting(Profile* profile) {

- return extensions::ExtensionPrefs::Get(profile)->app_sorting();

+ return extensions::ExtensionSystem::Get(profile)->app_sorting();

}

gfx::ImageSkia CreateDisabledIcon(const gfx::ImageSkia& icon) {