Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: chrome/browser/sync/test/integration/two_client_apps_sync_test.cc

Issue 1419823011: app_sorting() calls should go via ExtensionSystem intsead of prefs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes as per review comments. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/test/integration/two_client_apps_sync_test.cc
diff --git a/chrome/browser/sync/test/integration/two_client_apps_sync_test.cc b/chrome/browser/sync/test/integration/two_client_apps_sync_test.cc
index b24a7dd9f7c00b9608b3f71b18020c47dcff059e..8fa681ec57a21e4635ef2e7c367680d797dcc040 100644
--- a/chrome/browser/sync/test/integration/two_client_apps_sync_test.cc
+++ b/chrome/browser/sync/test/integration/two_client_apps_sync_test.cc
@@ -19,7 +19,6 @@
#include "content/public/browser/notification_service.h"
#include "content/public/test/test_utils.h"
#include "extensions/browser/app_sorting.h"
-#include "extensions/browser/extension_prefs.h"
#include "extensions/browser/extension_registry.h"
#include "extensions/browser/extension_system.h"
#include "extensions/common/constants.h"
@@ -334,14 +333,14 @@ IN_PROC_BROWSER_TEST_F(TwoClientAppsSyncTest, UpdateCWSOrdinals) {
// Change the app launch ordinal.
syncer::StringOrdinal cws_app_launch_ordinal =
- extensions::ExtensionPrefs::Get(GetProfile(0))
+ extensions::ExtensionSystem::Get(GetProfile(0))
->app_sorting()
->GetAppLaunchOrdinal(extensions::kWebStoreAppId);
- extensions::ExtensionPrefs::Get(GetProfile(0))
+ extensions::ExtensionSystem::Get(GetProfile(0))
->app_sorting()
->SetAppLaunchOrdinal(extensions::kWebStoreAppId,
cws_app_launch_ordinal.CreateAfter());
- extensions::ExtensionPrefs::Get(verifier())
+ extensions::ExtensionSystem::Get(verifier())
->app_sorting()
->SetAppLaunchOrdinal(extensions::kWebStoreAppId,
cws_app_launch_ordinal.CreateAfter());
@@ -349,13 +348,17 @@ IN_PROC_BROWSER_TEST_F(TwoClientAppsSyncTest, UpdateCWSOrdinals) {
// Change the page ordinal.
syncer::StringOrdinal cws_page_ordinal =
- extensions::ExtensionPrefs::Get(GetProfile(1))
+ extensions::ExtensionSystem::Get(GetProfile(1))
->app_sorting()
->GetPageOrdinal(extensions::kWebStoreAppId);
- extensions::ExtensionPrefs::Get(GetProfile(1))->app_sorting()->SetPageOrdinal(
- extensions::kWebStoreAppId, cws_page_ordinal.CreateAfter());
- extensions::ExtensionPrefs::Get(verifier())->app_sorting()->SetPageOrdinal(
- extensions::kWebStoreAppId, cws_page_ordinal.CreateAfter());
+ extensions::ExtensionSystem::Get(GetProfile(1))
+ ->app_sorting()
+ ->SetPageOrdinal(extensions::kWebStoreAppId,
+ cws_page_ordinal.CreateAfter());
+ extensions::ExtensionSystem::Get(verifier())
+ ->app_sorting()
+ ->SetPageOrdinal(extensions::kWebStoreAppId,
+ cws_page_ordinal.CreateAfter());
ASSERT_TRUE(AwaitAllProfilesHaveSameApps());
}
« no previous file with comments | « chrome/browser/sync/test/integration/sync_app_list_helper.cc ('k') | chrome/browser/ui/app_list/extension_app_item.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698