app_sorting() calls should go via ExtensionSystem intsead of prefs.

extensions/browser/extension_prefs.cc

Index: extensions/browser/extension_prefs.cc
diff --git a/extensions/browser/extension_prefs.cc b/extensions/browser/extension_prefs.cc
index 28d8db8cf76b7edfd5b273798f4d59f153e87c05..a790375bfbad17cb3eda8b61c7cc08c2a410fb61 100644
--- a/extensions/browser/extension_prefs.cc
+++ b/extensions/browser/extension_prefs.cc
@@ -377,6 +377,10 @@ static base::FilePath::StringType MakePathRelative(const base::FilePath& parent,
     return retval;
 }
 
+AppSorting* ExtensionPrefs::app_sorting() const {

[Dan Beam, 2015/11/12 22:37:21]

this should be positioned under ExtensionsPrefs constructor to match the .h
order

[benwells, 2015/11/12 23:33:48]

Unfortunately the file appears to be generally out of order. This function is
now correctly above ExtensionPrefs::MakePathsRelative but not correctly under
the constructor, because they're out of order already.

I'm not sure if its worth putting up another patch to correct the file
completely or not.

[Dan Beam, 2015/11/17 00:28:48]

then revert moving it to begin with

[Deepak, 2015/11/17 05:00:45]

Done.

+  return ExtensionSystem::Get(browser_context_)->app_sorting();
+}
+
 void ExtensionPrefs::MakePathsRelative() {
   const base::DictionaryValue* dict =
       prefs_->GetDictionary(pref_names::kExtensions);
@@ -1878,10 +1882,6 @@ ExtensionPrefs::ExtensionPrefs(
   InitPrefStore();
 }
 
-AppSorting* ExtensionPrefs::app_sorting() const {
-  return ExtensionSystem::Get(browser_context_)->app_sorting();
-}
-
 void ExtensionPrefs::SetNeedsStorageGarbageCollection(bool value) {
   prefs_->SetBoolean(pref_names::kStorageGarbageCollect, value);
 }