app_sorting() calls should go via ExtensionSystem intsead of prefs.

extensions/browser/extension_prefs.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/extension_prefs.h"
 
 #include <iterator>
 
 #include "base/metrics/histogram_macros.h"
 #include "base/prefs/pref_service.h"
@@ skipping 359 matching lines @@
     return child.value();
 
   base::FilePath::StringType retval = child.value().substr(
       parent.value().length());
   if (base::FilePath::IsSeparator(retval[0]))
     return retval.substr(1);
   else
     return retval;
 }
 
+AppSorting* ExtensionPrefs::app_sorting() const {

[Dan Beam, 2015/11/12 22:37:21]

this should be positioned under ExtensionsPrefs constructor to match the .h
order

[benwells, 2015/11/12 23:33:48]

Unfortunately the file appears to be generally out of order. This function is
now correctly above ExtensionPrefs::MakePathsRelative but not correctly under
the constructor, because they're out of order already.

I'm not sure if its worth putting up another patch to correct the file
completely or not.

[Dan Beam, 2015/11/17 00:28:48]

then revert moving it to begin with

[Deepak, 2015/11/17 05:00:45]

Done.

+  return ExtensionSystem::Get(browser_context_)->app_sorting();
+}
+
 void ExtensionPrefs::MakePathsRelative() {
   const base::DictionaryValue* dict =
       prefs_->GetDictionary(pref_names::kExtensions);
   if (!dict || dict->empty())
     return;
 
   // Collect all extensions ids with absolute paths in |absolute_keys|.
   std::set<std::string> absolute_keys;
   for (base::DictionaryValue::Iterator i(*dict); !i.IsAtEnd(); i.Advance()) {
     const base::DictionaryValue* extension_dict = NULL;
@@ skipping 1481 matching lines @@
   for (std::vector<ExtensionPrefsObserver*>::const_iterator iter =
            early_observers.begin();
        iter != early_observers.end();
        ++iter) {
     AddObserver(*iter);
   }
 
   InitPrefStore();
 }
 
-AppSorting* ExtensionPrefs::app_sorting() const {
-  return ExtensionSystem::Get(browser_context_)->app_sorting();
-}
-
 void ExtensionPrefs::SetNeedsStorageGarbageCollection(bool value) {
   prefs_->SetBoolean(pref_names::kStorageGarbageCollect, value);
 }
 
 bool ExtensionPrefs::NeedsStorageGarbageCollection() const {
   return prefs_->GetBoolean(pref_names::kStorageGarbageCollect);
 }
 
 // static
 void ExtensionPrefs::RegisterProfilePrefs(
@@ skipping 212 matching lines @@
   extension_pref_value_map_->RegisterExtension(
       extension_id, install_time, is_enabled, is_incognito_enabled);
 
   FOR_EACH_OBSERVER(
       ExtensionPrefsObserver,
       observer_list_,
       OnExtensionRegistered(extension_id, install_time, is_enabled));
 }
 
 }  // namespace extensions