Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: src/crankshaft/arm64/lithium-arm64.h

Issue 1419823003: Remove support for "loads and stores to global vars through property cell shortcuts inst… (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@disable-shortcuts
Patch Set: Addressing comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/crankshaft/arm/lithium-codegen-arm.cc ('k') | src/crankshaft/arm64/lithium-arm64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/crankshaft/arm64/lithium-arm64.h
diff --git a/src/crankshaft/arm64/lithium-arm64.h b/src/crankshaft/arm64/lithium-arm64.h
index c4ac70a75c33316877aafedfb8590a8b2276539e..cf9519f05a1488cef4a9d456c5b19fbf2ff0c1f7 100644
--- a/src/crankshaft/arm64/lithium-arm64.h
+++ b/src/crankshaft/arm64/lithium-arm64.h
@@ -102,7 +102,6 @@ class LCodeGen;
V(LoadFieldByIndex) \
V(LoadFunctionPrototype) \
V(LoadGlobalGeneric) \
- V(LoadGlobalViaContext) \
V(LoadKeyedExternal) \
V(LoadKeyedFixed) \
V(LoadKeyedFixedDouble) \
@@ -152,7 +151,6 @@ class LCodeGen;
V(StoreCodeEntry) \
V(StoreContextSlot) \
V(StoreFrameContext) \
- V(StoreGlobalViaContext) \
V(StoreKeyedExternal) \
V(StoreKeyedFixed) \
V(StoreKeyedFixedDouble) \
@@ -1650,22 +1648,6 @@ class LIsUndetectableAndBranch final : public LControlInstruction<1, 1> {
};
-class LLoadGlobalViaContext final : public LTemplateInstruction<1, 1, 1> {
- public:
- explicit LLoadGlobalViaContext(LOperand* context) { inputs_[0] = context; }
-
- DECLARE_CONCRETE_INSTRUCTION(LoadGlobalViaContext, "load-global-via-context")
- DECLARE_HYDROGEN_ACCESSOR(LoadGlobalViaContext)
-
- void PrintDataTo(StringStream* stream) override;
-
- LOperand* context() { return inputs_[0]; }
-
- int depth() const { return hydrogen()->depth(); }
- int slot_index() const { return hydrogen()->slot_index(); }
-};
-
-
class LLoadContextSlot final : public LTemplateInstruction<1, 1, 0> {
public:
explicit LLoadContextSlot(LOperand* context) {
@@ -2435,28 +2417,6 @@ class LStackCheck final : public LTemplateInstruction<0, 1, 0> {
};
-class LStoreGlobalViaContext final : public LTemplateInstruction<0, 2, 0> {
- public:
- LStoreGlobalViaContext(LOperand* context, LOperand* value) {
- inputs_[0] = context;
- inputs_[1] = value;
- }
-
- LOperand* context() { return inputs_[0]; }
- LOperand* value() { return inputs_[1]; }
-
- DECLARE_CONCRETE_INSTRUCTION(StoreGlobalViaContext,
- "store-global-via-context")
- DECLARE_HYDROGEN_ACCESSOR(StoreGlobalViaContext)
-
- void PrintDataTo(StringStream* stream) override;
-
- int depth() { return hydrogen()->depth(); }
- int slot_index() { return hydrogen()->slot_index(); }
- LanguageMode language_mode() { return hydrogen()->language_mode(); }
-};
-
-
template<int T>
class LStoreKeyed : public LTemplateInstruction<0, 3, T> {
public:
« no previous file with comments | « src/crankshaft/arm/lithium-codegen-arm.cc ('k') | src/crankshaft/arm64/lithium-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698