Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Side by Side Diff: src/crankshaft/arm64/lithium-arm64.h

Issue 1419823003: Remove support for "loads and stores to global vars through property cell shortcuts inst… (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@disable-shortcuts
Patch Set: Addressing comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/arm/lithium-codegen-arm.cc ('k') | src/crankshaft/arm64/lithium-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_CRANKSHAFT_ARM64_LITHIUM_ARM64_H_ 5 #ifndef V8_CRANKSHAFT_ARM64_LITHIUM_ARM64_H_
6 #define V8_CRANKSHAFT_ARM64_LITHIUM_ARM64_H_ 6 #define V8_CRANKSHAFT_ARM64_LITHIUM_ARM64_H_
7 7
8 #include "src/crankshaft/hydrogen.h" 8 #include "src/crankshaft/hydrogen.h"
9 #include "src/crankshaft/lithium.h" 9 #include "src/crankshaft/lithium.h"
10 #include "src/crankshaft/lithium-allocator.h" 10 #include "src/crankshaft/lithium-allocator.h"
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 V(IsConstructCallAndBranch) \ 95 V(IsConstructCallAndBranch) \
96 V(IsSmiAndBranch) \ 96 V(IsSmiAndBranch) \
97 V(IsStringAndBranch) \ 97 V(IsStringAndBranch) \
98 V(IsUndetectableAndBranch) \ 98 V(IsUndetectableAndBranch) \
99 V(Label) \ 99 V(Label) \
100 V(LazyBailout) \ 100 V(LazyBailout) \
101 V(LoadContextSlot) \ 101 V(LoadContextSlot) \
102 V(LoadFieldByIndex) \ 102 V(LoadFieldByIndex) \
103 V(LoadFunctionPrototype) \ 103 V(LoadFunctionPrototype) \
104 V(LoadGlobalGeneric) \ 104 V(LoadGlobalGeneric) \
105 V(LoadGlobalViaContext) \
106 V(LoadKeyedExternal) \ 105 V(LoadKeyedExternal) \
107 V(LoadKeyedFixed) \ 106 V(LoadKeyedFixed) \
108 V(LoadKeyedFixedDouble) \ 107 V(LoadKeyedFixedDouble) \
109 V(LoadKeyedGeneric) \ 108 V(LoadKeyedGeneric) \
110 V(LoadNamedField) \ 109 V(LoadNamedField) \
111 V(LoadNamedGeneric) \ 110 V(LoadNamedGeneric) \
112 V(LoadRoot) \ 111 V(LoadRoot) \
113 V(MapEnumLength) \ 112 V(MapEnumLength) \
114 V(MathAbs) \ 113 V(MathAbs) \
115 V(MathAbsTagged) \ 114 V(MathAbsTagged) \
(...skipping 29 matching lines...) Expand all
145 V(SeqStringGetChar) \ 144 V(SeqStringGetChar) \
146 V(SeqStringSetChar) \ 145 V(SeqStringSetChar) \
147 V(ShiftI) \ 146 V(ShiftI) \
148 V(ShiftS) \ 147 V(ShiftS) \
149 V(SmiTag) \ 148 V(SmiTag) \
150 V(SmiUntag) \ 149 V(SmiUntag) \
151 V(StackCheck) \ 150 V(StackCheck) \
152 V(StoreCodeEntry) \ 151 V(StoreCodeEntry) \
153 V(StoreContextSlot) \ 152 V(StoreContextSlot) \
154 V(StoreFrameContext) \ 153 V(StoreFrameContext) \
155 V(StoreGlobalViaContext) \
156 V(StoreKeyedExternal) \ 154 V(StoreKeyedExternal) \
157 V(StoreKeyedFixed) \ 155 V(StoreKeyedFixed) \
158 V(StoreKeyedFixedDouble) \ 156 V(StoreKeyedFixedDouble) \
159 V(StoreKeyedGeneric) \ 157 V(StoreKeyedGeneric) \
160 V(StoreNamedField) \ 158 V(StoreNamedField) \
161 V(StoreNamedGeneric) \ 159 V(StoreNamedGeneric) \
162 V(StringAdd) \ 160 V(StringAdd) \
163 V(StringCharCodeAt) \ 161 V(StringCharCodeAt) \
164 V(StringCharFromCode) \ 162 V(StringCharFromCode) \
165 V(StringCompareAndBranch) \ 163 V(StringCompareAndBranch) \
(...skipping 1477 matching lines...) Expand 10 before | Expand all | Expand 10 after
1643 LOperand* temp() { return temps_[0]; } 1641 LOperand* temp() { return temps_[0]; }
1644 1642
1645 DECLARE_CONCRETE_INSTRUCTION(IsUndetectableAndBranch, 1643 DECLARE_CONCRETE_INSTRUCTION(IsUndetectableAndBranch,
1646 "is-undetectable-and-branch") 1644 "is-undetectable-and-branch")
1647 DECLARE_HYDROGEN_ACCESSOR(IsUndetectableAndBranch) 1645 DECLARE_HYDROGEN_ACCESSOR(IsUndetectableAndBranch)
1648 1646
1649 void PrintDataTo(StringStream* stream) override; 1647 void PrintDataTo(StringStream* stream) override;
1650 }; 1648 };
1651 1649
1652 1650
1653 class LLoadGlobalViaContext final : public LTemplateInstruction<1, 1, 1> {
1654 public:
1655 explicit LLoadGlobalViaContext(LOperand* context) { inputs_[0] = context; }
1656
1657 DECLARE_CONCRETE_INSTRUCTION(LoadGlobalViaContext, "load-global-via-context")
1658 DECLARE_HYDROGEN_ACCESSOR(LoadGlobalViaContext)
1659
1660 void PrintDataTo(StringStream* stream) override;
1661
1662 LOperand* context() { return inputs_[0]; }
1663
1664 int depth() const { return hydrogen()->depth(); }
1665 int slot_index() const { return hydrogen()->slot_index(); }
1666 };
1667
1668
1669 class LLoadContextSlot final : public LTemplateInstruction<1, 1, 0> { 1651 class LLoadContextSlot final : public LTemplateInstruction<1, 1, 0> {
1670 public: 1652 public:
1671 explicit LLoadContextSlot(LOperand* context) { 1653 explicit LLoadContextSlot(LOperand* context) {
1672 inputs_[0] = context; 1654 inputs_[0] = context;
1673 } 1655 }
1674 1656
1675 LOperand* context() { return inputs_[0]; } 1657 LOperand* context() { return inputs_[0]; }
1676 1658
1677 DECLARE_CONCRETE_INSTRUCTION(LoadContextSlot, "load-context-slot") 1659 DECLARE_CONCRETE_INSTRUCTION(LoadContextSlot, "load-context-slot")
1678 DECLARE_HYDROGEN_ACCESSOR(LoadContextSlot) 1660 DECLARE_HYDROGEN_ACCESSOR(LoadContextSlot)
(...skipping 749 matching lines...) Expand 10 before | Expand all | Expand 10 after
2428 DECLARE_CONCRETE_INSTRUCTION(StackCheck, "stack-check") 2410 DECLARE_CONCRETE_INSTRUCTION(StackCheck, "stack-check")
2429 DECLARE_HYDROGEN_ACCESSOR(StackCheck) 2411 DECLARE_HYDROGEN_ACCESSOR(StackCheck)
2430 2412
2431 Label* done_label() { return &done_label_; } 2413 Label* done_label() { return &done_label_; }
2432 2414
2433 private: 2415 private:
2434 Label done_label_; 2416 Label done_label_;
2435 }; 2417 };
2436 2418
2437 2419
2438 class LStoreGlobalViaContext final : public LTemplateInstruction<0, 2, 0> {
2439 public:
2440 LStoreGlobalViaContext(LOperand* context, LOperand* value) {
2441 inputs_[0] = context;
2442 inputs_[1] = value;
2443 }
2444
2445 LOperand* context() { return inputs_[0]; }
2446 LOperand* value() { return inputs_[1]; }
2447
2448 DECLARE_CONCRETE_INSTRUCTION(StoreGlobalViaContext,
2449 "store-global-via-context")
2450 DECLARE_HYDROGEN_ACCESSOR(StoreGlobalViaContext)
2451
2452 void PrintDataTo(StringStream* stream) override;
2453
2454 int depth() { return hydrogen()->depth(); }
2455 int slot_index() { return hydrogen()->slot_index(); }
2456 LanguageMode language_mode() { return hydrogen()->language_mode(); }
2457 };
2458
2459
2460 template<int T> 2420 template<int T>
2461 class LStoreKeyed : public LTemplateInstruction<0, 3, T> { 2421 class LStoreKeyed : public LTemplateInstruction<0, 3, T> {
2462 public: 2422 public:
2463 LStoreKeyed(LOperand* elements, LOperand* key, LOperand* value) { 2423 LStoreKeyed(LOperand* elements, LOperand* key, LOperand* value) {
2464 this->inputs_[0] = elements; 2424 this->inputs_[0] = elements;
2465 this->inputs_[1] = key; 2425 this->inputs_[1] = key;
2466 this->inputs_[2] = value; 2426 this->inputs_[2] = value;
2467 } 2427 }
2468 2428
2469 bool is_external() const { return this->hydrogen()->is_external(); } 2429 bool is_external() const { return this->hydrogen()->is_external(); }
(...skipping 781 matching lines...) Expand 10 before | Expand all | Expand 10 after
3251 DISALLOW_COPY_AND_ASSIGN(LChunkBuilder); 3211 DISALLOW_COPY_AND_ASSIGN(LChunkBuilder);
3252 }; 3212 };
3253 3213
3254 #undef DECLARE_HYDROGEN_ACCESSOR 3214 #undef DECLARE_HYDROGEN_ACCESSOR
3255 #undef DECLARE_CONCRETE_INSTRUCTION 3215 #undef DECLARE_CONCRETE_INSTRUCTION
3256 3216
3257 } // namespace internal 3217 } // namespace internal
3258 } // namespace v8 3218 } // namespace v8
3259 3219
3260 #endif // V8_CRANKSHAFT_ARM64_LITHIUM_ARM64_H_ 3220 #endif // V8_CRANKSHAFT_ARM64_LITHIUM_ARM64_H_
OLDNEW
« no previous file with comments | « src/crankshaft/arm/lithium-codegen-arm.cc ('k') | src/crankshaft/arm64/lithium-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698