src/js/array.js - Issue 1419813010: [runtime] Remove the very dangerous %_CallFunction intrinsic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/js/array.js

Issue 1419813010: [runtime] Remove the very dangerous %_CallFunction intrinsic. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/js/array.js

diff --git a/src/js/array.js b/src/js/array.js

index b9a49284e73ef0f45d06513924b758a37952a6db..294e474be6ea9dfd4ba688e7a98f5e59a2f18ee4 100644

--- a/src/js/array.js

+++ b/src/js/array.js

@@ -405,7 +405,7 @@ function ArrayToString() {

func = array.join;

}

if (!IS_CALLABLE(func)) {

- return %_CallFunction(array, ObjectToString);

+ return %_Call(ObjectToString, array);

}

return %_Call(func, array);

}

« no previous file with comments | « src/full-codegen/x87/full-codegen-x87.cc ('k') | src/js/code-stubs.js » ('j') | no next file with comments »