Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1419783013: Move ChromiumPortAllocatorFactory to remoting/protocol (Closed)

Created:
5 years, 1 month ago by Sergey Ulanov
Modified:
5 years, 1 month ago
Reviewers:
Jamie
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move ChromiumPortAllocatorFactory to remoting/protocol BUG=547158 Committed: https://crrev.com/a8742f45d5dda772cedb35f5b57662678fd580fb Cr-Commit-Position: refs/heads/master@{#358751}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -128 lines) Patch
M remoting/host/cast_extension_session.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D remoting/host/chromium_port_allocator_factory.h View 1 chunk +0 lines, -49 lines 0 comments Download
D remoting/host/chromium_port_allocator_factory.cc View 1 chunk +0 lines, -55 lines 0 comments Download
M remoting/protocol/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A + remoting/protocol/chromium_port_allocator_factory.h View 3 chunks +10 lines, -10 lines 0 comments Download
A + remoting/protocol/chromium_port_allocator_factory.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M remoting/remoting_host_srcs.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/remoting_nacl.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/remoting_srcs.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Sergey Ulanov
5 years, 1 month ago (2015-11-10 00:49:11 UTC) #3
Jamie
lgtm
5 years, 1 month ago (2015-11-10 00:51:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419783013/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419783013/40001
5 years, 1 month ago (2015-11-10 00:54:41 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years, 1 month ago (2015-11-10 02:14:23 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 02:15:13 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a8742f45d5dda772cedb35f5b57662678fd580fb
Cr-Commit-Position: refs/heads/master@{#358751}

Powered by Google App Engine
This is Rietveld 408576698